New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-2707: Add Resources feature #1840
RUM-2707: Add Resources feature #1840
Conversation
2a1c280
to
54160e9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1840 +/- ##
===========================================
+ Coverage 83.21% 83.28% +0.07%
===========================================
Files 470 475 +5
Lines 16632 16721 +89
Branches 2494 2503 +9
===========================================
+ Hits 13839 13925 +86
- Misses 2103 2105 +2
- Partials 690 691 +1
|
03d02e0
to
e60f49f
Compare
...ession-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/ResourcesFeature.kt
Outdated
Show resolved
Hide resolved
...-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/ResourceWriter.kt
Outdated
Show resolved
Hide resolved
...lay/src/main/kotlin/com/datadog/android/sessionreplay/internal/processor/EnrichedResource.kt
Outdated
Show resolved
Hide resolved
...on-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/SessionReplayFeature.kt
Outdated
Show resolved
Hide resolved
...on-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/SessionReplayFeature.kt
Outdated
Show resolved
Hide resolved
...ession-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/ResourcesFeature.kt
Outdated
Show resolved
Hide resolved
...ession-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/ResourcesFeature.kt
Show resolved
Hide resolved
...ession-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/ResourcesFeature.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/datadog/android/sessionreplay/internal/async/ResourceRecordedDataQueueItemTest.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/datadog/android/sessionreplay/internal/storage/SessionReplayResourceWriterTest.kt
Outdated
Show resolved
Hide resolved
e60f49f
to
e00f01b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from @0xnm comments
39be041
to
67c70a6
Compare
11c1fc4
to
4dd4279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. added few comments, but they are not blocking.
sdkCore.setEventReceiver(SESSION_REPLAY_FEATURE_NAME, this) | ||
if (RESOURCES_ENDPOINT_ENABLED) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is always false
, so I guess I guess for now it is a feature flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - it's a ff that we'll remove in a later pr
...on-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/SessionReplayFeature.kt
Show resolved
Hide resolved
...on-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/SessionReplayFeature.kt
Show resolved
Hide resolved
...on-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/SessionReplayFeature.kt
Outdated
Show resolved
Hide resolved
...lay/src/main/kotlin/com/datadog/android/sessionreplay/internal/processor/EnrichedResource.kt
Outdated
Show resolved
Hide resolved
...on-replay/src/test/kotlin/com/datadog/android/sessionreplay/internal/ResourcesFeatureTest.kt
Show resolved
Hide resolved
...otlin/com/datadog/android/sessionreplay/forge/ResourceRecordedDataQueueItemForgeryFactory.kt
Outdated
Show resolved
Hide resolved
e5670ac
to
604b282
Compare
23467e0
to
cbd637a
Compare
604b282
to
92da6ed
Compare
What does this PR do?
Adds a new resource feature, created inside the session replay feature, in order to handle resources captured during traversal
Motivation
Part of the resource endpoint
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)