New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-2709: Implement resource capture during traversal #1854
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1854 +/- ##
===========================================
+ Coverage 83.23% 83.29% +0.06%
===========================================
Files 478 479 +1
Lines 16884 16934 +50
Branches 2519 2526 +7
===========================================
+ Hits 14052 14104 +52
Misses 2136 2136
+ Partials 696 694 -2
|
3194f1a
to
de66c39
Compare
1d3c889
to
35c1f37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went though the production files and left some questions, didn't go through the tests yet.
...c/main/kotlin/com/datadog/android/sessionreplay/internal/recorder/base64/Base64Serializer.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/datadog/android/sessionreplay/internal/recorder/base64/Base64Serializer.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/datadog/android/sessionreplay/internal/recorder/base64/Base64Serializer.kt
Show resolved
Hide resolved
...lay/src/main/kotlin/com/datadog/android/sessionreplay/internal/processor/EnrichedResource.kt
Outdated
Show resolved
Hide resolved
...lay/src/main/kotlin/com/datadog/android/sessionreplay/internal/processor/EnrichedResource.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/com/datadog/android/sessionreplay/internal/net/ResourceRequestBodyFactory.kt
Outdated
Show resolved
Hide resolved
...lay/src/main/kotlin/com/datadog/android/sessionreplay/internal/async/NoopDataQueueHandler.kt
Outdated
Show resolved
Hide resolved
...eplay/src/test/kotlin/com/datadog/android/sessionreplay/internal/SessionReplayFeatureTest.kt
Outdated
Show resolved
Hide resolved
...oid-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayPrivacy.kt
Show resolved
Hide resolved
...-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/async/DataQueueHandler.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I partially reviewed it but would need first some answers to figure it out the rest.
...ion-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/utils/DrawableUtils.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once @0xnm comments will be addressed I am ok to approve it. For me the biggest blocker was the Base64Serializer
but as you said it will be addressed in the next PR.
03efd64
to
a31af69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! I left some comments, but nothing blocking.
...lay/src/main/kotlin/com/datadog/android/sessionreplay/internal/processor/EnrichedResource.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/datadog/android/sessionreplay/internal/recorder/base64/Base64Serializer.kt
Outdated
Show resolved
Hide resolved
...test/kotlin/com/datadog/android/sessionreplay/internal/async/RecordedDataQueueHandlerTest.kt
Outdated
Show resolved
Hide resolved
...src/test/kotlin/com/datadog/android/sessionreplay/internal/processor/EnrichedResourceTest.kt
Outdated
Show resolved
Hide resolved
604b282
to
92da6ed
Compare
ef39f54
to
7dcc78c
Compare
7dcc78c
to
79cacc9
Compare
What does this PR do?
Captures the bitmaps during traversal and writes them to batches
Motivation
Third PR of the Resource endpoint
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)