Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add source_type when sent from cross platform logs #1895

Merged
merged 1 commit into from Mar 1, 2024

Conversation

fuzzybinary
Copy link
Contributor

What does this PR do?

This will send source_type as a property on error when the attribute _dd.error.source_type is set on the log.

Motivation

The source_type property is not being populated on logs. This isn't too big of an issue as symbolication will default back to source, but there are cases where we'll need the source_type to do proper symbolication.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary fuzzybinary requested review from a team as code owners February 29, 2024 14:47
Send `source_type` as a property on `error` when the attribute `_dd.error.source_type` is set on the log.
@codecov-commenter
Copy link

Codecov Report

Merging #1895 (5cb4f3e) into develop (9c75335) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1895      +/-   ##
===========================================
- Coverage    83.33%   83.32%   -0.01%     
===========================================
  Files          479      479              
  Lines        16952    16955       +3     
  Branches      2527     2528       +1     
===========================================
+ Hits         14126    14127       +1     
- Misses        2133     2136       +3     
+ Partials       693      692       -1     
Files Coverage Δ
...in/kotlin/com/datadog/android/log/LogAttributes.kt 0.00% <ø> (ø)
...android/log/internal/domain/DatadogLogGenerator.kt 97.97% <100.00%> (+0.06%) ⬆️

... and 33 files with indirect coverage changes

@fuzzybinary fuzzybinary merged commit cce49b2 into develop Mar 1, 2024
23 checks passed
@fuzzybinary fuzzybinary deleted the jward/source_type branch March 1, 2024 14:28
@xgouchet xgouchet added this to the 2.7.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants