Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in source type #1904

Merged
merged 1 commit into from Mar 5, 2024
Merged

Fix typo in source type #1904

merged 1 commit into from Mar 5, 2024

Conversation

fuzzybinary
Copy link
Contributor

What does this PR do?

The log attribute for source type had a . instead of an _ which breaks the cross platform contract.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary fuzzybinary marked this pull request as ready for review March 5, 2024 15:40
@fuzzybinary fuzzybinary requested review from a team as code owners March 5, 2024 15:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Merging #1904 (0ee7d13) into develop (0e3a8b0) will decrease coverage by 0.23%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1904      +/-   ##
===========================================
- Coverage    83.44%   83.21%   -0.23%     
===========================================
  Files          477      477              
  Lines        16911    16877      -34     
  Branches      2512     2507       -5     
===========================================
- Hits         14110    14043      -67     
- Misses        2113     2134      +21     
- Partials       688      700      +12     
Files Coverage Δ
...in/kotlin/com/datadog/android/log/LogAttributes.kt 0.00% <ø> (ø)

... and 29 files with indirect coverage changes

@fuzzybinary fuzzybinary merged commit 87f81fe into develop Mar 5, 2024
23 checks passed
@fuzzybinary fuzzybinary deleted the jward/fix-attribute branch March 5, 2024 20:59
@xgouchet xgouchet added this to the 2.7.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants