Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2879: Disable non-fatal ANR reporting by default #1914

Merged
merged 1 commit into from Mar 18, 2024

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Mar 14, 2024

What does this PR do?

This PR disables non-fatal ANR reporting (the one which is using watchdog approach) by default for API 30+, but keeps it enabled on Android API 29 and below (because there is no fatal ANR reporting there).

Customer now has an opportunity to explicitly enable/disable it.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners March 14, 2024 13:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Merging #1914 (5d54877) into develop (5ffa623) will decrease coverage by 0.04%.
Report is 10 commits behind head on develop.
The diff coverage is 80.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1914      +/-   ##
===========================================
- Coverage    83.43%   83.39%   -0.04%     
===========================================
  Files          478      478              
  Lines        17124    17142      +18     
  Branches      2558     2565       +7     
===========================================
+ Hits         14286    14295       +9     
- Misses        2135     2140       +5     
- Partials       703      707       +4     
Files Coverage Δ
...kotlin/com/datadog/android/rum/RumConfiguration.kt 96.83% <100.00%> (+0.10%) ⬆️
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.38% <76.92%> (-1.16%) ⬇️

... and 21 files with indirect coverage changes

Base automatically changed from nogorodnikov/rum-2878/sdk-captures-and-reports-fatal-anrs to develop March 18, 2024 09:34
@0xnm 0xnm merged commit 72d5aeb into develop Mar 18, 2024
22 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-2879/opt-in-non-fatal-anr-reporting branch March 18, 2024 10:14
@xgouchet xgouchet added this to the 2.7.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants