Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the safe events serialization produced by RumViewScope in multi-threaded environment #1933

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Mar 22, 2024

What does this PR do?

This test emulates updates for the RumViewScope in one thread and serialization of events produced in another thread. It shouldn't be any issues doing that.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners March 22, 2024 10:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Merging #1933 (e11172e) into develop (684f5b4) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1933      +/-   ##
===========================================
+ Coverage    83.31%   83.37%   +0.06%     
===========================================
  Files          481      481              
  Lines        17412    17407       -5     
  Branches      2588     2590       +2     
===========================================
+ Hits         14506    14513       +7     
+ Misses        2195     2190       -5     
+ Partials       711      704       -7     
Files Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 94.10% <100.00%> (+0.74%) ⬆️

... and 27 files with indirect coverage changes

@0xnm 0xnm merged commit caf8102 into develop Mar 25, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/add-test-for-safe-events-serialization-from-rum-view-scope branch March 25, 2024 08:38
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants