Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3670 backpressure strategy #1938

Merged
merged 4 commits into from Mar 26, 2024

Conversation

xgouchet
Copy link
Collaborator

What does this PR do?

Create a BackPressure setting and BackPressure compatible BlockingQueue (will be used in a follow up PR)

@xgouchet xgouchet requested review from a team as code owners March 25, 2024 17:30
@xgouchet xgouchet force-pushed the xgouchet/RUM-3670/backpressure_strategy branch from 8952e8f to f389406 Compare March 25, 2024 17:46
@xgouchet xgouchet force-pushed the xgouchet/RUM-3670/backpressure_strategy branch from f389406 to a298751 Compare March 25, 2024 19:53
mariusc83
mariusc83 previously approved these changes Mar 26, 2024
Copy link
Collaborator

@mariusc83 mariusc83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done !!

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Merging #1938 (707aa84) into release/2.7.0 (9d7e3f9) will decrease coverage by 0.23%.
Report is 4 commits behind head on release/2.7.0.
The diff coverage is 77.38%.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/2.7.0    #1938      +/-   ##
=================================================
- Coverage          83.56%   83.33%   -0.23%     
=================================================
  Files                481      485       +4     
  Lines              17413    17465      +52     
  Branches            2590     2591       +1     
=================================================
+ Hits               14550    14553       +3     
- Misses              2177     2202      +25     
- Partials             686      710      +24     
Files Coverage Δ
...droid/core/configuration/BackPressureMitigation.kt 100.00% <100.00%> (ø)
...android/core/configuration/BackPressureStrategy.kt 100.00% <100.00%> (ø)
...atadog/android/core/configuration/Configuration.kt 95.05% <83.33%> (-1.65%) ⬇️
...core/internal/thread/BackPressuredBlockingQueue.kt 94.87% <94.87%> (ø)
...ore/internal/thread/BackPressureExecutorService.kt 42.31% <42.31%> (ø)

... and 25 files with indirect coverage changes

Copy link
Contributor

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! I added some questions for the better understanding.

@xgouchet xgouchet merged commit c9243d1 into release/2.7.0 Mar 26, 2024
23 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-3670/backpressure_strategy branch March 26, 2024 16:27
@xgouchet xgouchet added this to the 2.7.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants