RUM-3532 keep webview wireframe hidden #1949
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/sr-web-view-support #1949 +/- ##
===============================================================
- Coverage 83.56% 83.53% -0.03%
===============================================================
Files 486 487 +1
Lines 17439 17674 +235
Branches 2594 2646 +52
===============================================================
+ Hits 14572 14763 +191
- Misses 2143 2172 +29
- Partials 724 739 +15
|
| android:title="@string/webview_hide" | ||
| android:id="@+id/webview_hide" | ||
| /> | ||
| </menu> |
There was a problem hiding this comment.
| </menu> | |
| </menu> | |
| ActivityViewTrackingStrategy(true) | ||
| // NavigationViewTrackingStrategy( | ||
| // R.id.nav_host_fragment, | ||
| // true, | ||
| // SampleNavigationPredicate() | ||
| // ) |
There was a problem hiding this comment.
it is for the test or permanent change?
| ARG_PAGE_NAME to "Fragment C", | ||
| ARG_WEB_VIEW_URL to | ||
| "https://datadoghq.dev/browser-sdk-test-playground/" + | ||
| "?client_token=${BuildConfig.DD_CLIENT_TOKEN}" + |
There was a problem hiding this comment.
probably we don't want the client token to be recorded here, application ID as well. Should we use the URL from FragmentA/FragmentB?
There was a problem hiding this comment.
It's the same code as in the webview fragment, and the client token is necessary for this page.
Also the goal is to have different content to ensure the replay works (if all fragments load the same page it's hard to make sure each webview is handled independently and consistently)
| "https://datadoghq.dev/browser-sdk-test-playground/" + | ||
| "?client_token=${BuildConfig.DD_CLIENT_TOKEN}" + | ||
| "&application_id=${BuildConfig.DD_RUM_APPLICATION_ID}" + | ||
| "&site=datadoghq.com" |
There was a problem hiding this comment.
should we have here a site used by the app/SDK? the one from BuildConfig.DD_SITE_NAME
sample/kotlin/src/main/kotlin/com/datadog/android/sample/webview/DatadogSiteExt.kt
Show resolved
Hide resolved
What does this PR do?
In order to keep webviews consistent in session replays, instead of removing them from the segments when computing a diff, we keep them and mark them as hidden.