RUMM-3774 prevent crash in Canvas Wrapper #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
approved these changes
Mar 29, 2024
| return null | ||
| } | ||
|
|
||
| @Suppress("TooGenericExceptionCaught") | ||
| return try { | ||
| Canvas(bitmap) | ||
| } catch (e: IllegalStateException) { |
There was a problem hiding this comment.
minor: the comment on the line below should be updated to should never happen since we are passing a mutable bitmap
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1954 +/- ##
===========================================
- Coverage 83.19% 83.13% -0.06%
===========================================
Files 486 486
Lines 17560 17546 -14
Branches 2603 2601 -2
===========================================
- Hits 14609 14586 -23
- Misses 2249 2254 +5
- Partials 702 706 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds several checks to ensure the bitmap can be used in a canvas.
Fixes #1952