Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TodoWithoutTask tests #1962

Merged
merged 1 commit into from Apr 3, 2024

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Apr 3, 2024

What does this PR do?

Regex [A-Z]+-\\d{1,8} may generate something like ABC-0 because of the d{1,8}, and this will fail some tests, because 0 as a task number is not allowed.

This PR fixes that.

Note: In theory it is possible to have something like ABC-012, but generating 012 and avoiding to have all zeros at the same time requires using matching groups/negative lookaheads, which is not supported by Forge.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners April 3, 2024 07:36
Copy link
Collaborator

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks

@codecov-commenter
Copy link

Codecov Report

Merging #1962 (b2dfe31) into develop (a107d7c) will increase coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1962      +/-   ##
===========================================
+ Coverage    83.24%   83.37%   +0.13%     
===========================================
  Files          489      489              
  Lines        17857    17827      -30     
  Branches      2661     2654       -7     
===========================================
- Hits         14865    14863       -2     
+ Misses        2264     2243      -21     
+ Partials       728      721       -7     

see 27 files with indirect coverage changes

@0xnm 0xnm merged commit ddd5f7b into develop Apr 3, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/fix-flaky-todo-without-task-tests branch April 3, 2024 09:37
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants