RUM-3757: Make sure error.threads
always have content from error.stack
#1964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It seems sometimes it is possible to have result of
Thread.getAllStackTraces()
without the thread impacted by ANR/crashing thread info (or without attached stacktrace, not sure here). It is not clear why it happens, but we clearly can see such issues in the dashboard, whenerror.stack
is not found amongerror.threads
reported (meaningerror.threads
doesn't have thread for which we reportingerror.stack
).This change fixes that by making sure ANR thread/crashing thread is always in the
error.threads
- we will always add it to the list, not relying on the match amongThread.getAllStackTraces()
results.Review checklist (to be filled by reviewers)