Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #1967

Merged
merged 5 commits into from Apr 4, 2024
Merged

Fix flaky tests #1967

merged 5 commits into from Apr 4, 2024

Conversation

xgouchet
Copy link
Collaborator

@xgouchet xgouchet commented Apr 4, 2024

What does this PR do?

This commit attemps to fix several tests that are regularly flaky in CI

@xgouchet xgouchet requested review from a team as code owners April 4, 2024 11:39
@@ -756,7 +756,7 @@ internal class DatadogCoreTest {

@Test
fun `𝕄 stop all features 𝕎 stop()`(
@StringForgery fakeFeatureNames: List<String>
@StringForgery fakeFeatureNames: Set<String>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already here #1965 :)

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

Merging #1967 (a1cf20b) into develop (fb5a1de) will increase coverage by 0.01%.
Report is 6 commits behind head on develop.
The diff coverage is 75.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1967      +/-   ##
===========================================
+ Coverage    83.31%   83.33%   +0.01%     
===========================================
  Files          489      489              
  Lines        17883    17875       -8     
  Branches      2666     2669       +3     
===========================================
- Hits         14899    14895       -4     
+ Misses        2240     2239       -1     
+ Partials       744      741       -3     
Files Coverage Δ
...core/internal/system/DefaultAndroidInfoProvider.kt 79.59% <75.00%> (-5.19%) ⬇️

... and 26 files with indirect coverage changes

@xgouchet xgouchet merged commit 337e299 into develop Apr 4, 2024
23 checks passed
@xgouchet xgouchet deleted the xgouchet/flaky_tests branch April 4, 2024 14:53
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants