Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3486: Remove non-ASCII characters from test names #1973

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Apr 8, 2024

What does this PR do?

This PR removes non-ASCII characters from test names to be compatible with Kotlin 1.8.20+, see https://youtrack.jetbrains.com/issue/KT-60748 for more details.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners April 8, 2024 11:55
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Merging #1973 (ccc9e1f) into develop (0706c32) will decrease coverage by 0.20%.
Report is 9 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1973      +/-   ##
===========================================
- Coverage    83.58%   83.38%   -0.20%     
===========================================
  Files          489      489              
  Lines        17932    17925       -7     
  Branches      2671     2670       -1     
===========================================
- Hits         14987    14945      -42     
- Misses        2226     2249      +23     
- Partials       719      731      +12     

see 32 files with indirect coverage changes

Copy link
Collaborator

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@0xnm 0xnm merged commit 3de2fae into develop Apr 9, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-3486/remove-non-ascii-characters-from-test-names branch April 9, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants