-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OkHttp to 4.12.0 #1975
base: develop
Are you sure you want to change the base?
Update OkHttp to 4.12.0 #1975
Conversation
8382ae8
to
1b24ca1
Compare
1b24ca1
to
4797af9
Compare
@@ -2,7 +2,7 @@ Dependencies List | |||
|
|||
androidx.annotation:annotation:1.3.0 : 30 Kb | |||
com.google.code.gson:gson:2.10.1 : 276 Kb | |||
org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 : 216 Kb | |||
org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10 : 219 Kb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are updating to 1.9
here but in the prev PR you mentioned that this is not yet recommended. Are we safe here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we don't update compiler, so in theory it is safe, but I'm going to keep this PR on hold anyway, because of Kotlin 1.9 stdlib usage. Once we are confirmed that we are fine with Kotlin 1.9, we can merge this one.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1975 +/- ##
===========================================
+ Coverage 83.61% 83.69% +0.08%
===========================================
Files 487 487
Lines 17742 17699 -43
Branches 2664 2656 -8
===========================================
- Hits 14834 14812 -22
+ Misses 2187 2164 -23
- Partials 721 723 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question...
What does this PR do?
This PR updates OkHttp version to 4.12.0, changelog is here https://square.github.io/okhttp/changelogs/changelog_4x/
Review checklist (to be filled by reviewers)