RUM-3992 Prevent crash in JankStats listener #1981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1976
In Android N (until Android P included), the internal View. findFrameMetricsObserver() method did not check the nullability of the
mFrameMetricsObservers
field, leading to possible NPE when trying to remove a listener that wasn't yet added.Motivation
Some customer have seen a crash with an NPE thrown from the Android View when removing the
FrameMetricsListener
via theJankStats
library.Even though all versions of the official Android View are written in a way that NPE should never happen, those crash still occurred.