Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3861 Update testing ci steps to limit OOM and memory usage #1986

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

xgouchet
Copy link
Collaborator

What does this PR do?

Updates our CI to

  • spread the load of the runner during our most intensive jobs
  • add an OOM dump artifact if this reappears in the future

@xgouchet xgouchet requested review from a team as code owners April 15, 2024 10:13
.codecov.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we remove codecov? I find it useful, I rely on the data I receive for each PR to see the coverage change and if any files touched in the PR are not covered enough.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov was run as part of the kover job that we agreed to remove.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'll do is replace the test:release with test:kover then

@@ -53,7 +53,7 @@ jobs:

# Manually build the java bytecode
- name: Execute Gradle build
run: ./gradlew assembleLibraries
run: ./gradlew assembleLibrariesDebug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we still need to build both build types (because it is a security scan, it needs to cover everything) or at least release build type instead of debug, because release is what will be used by the customer later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point I'll switch to release

CONTRIBUTING.md Outdated
./gradlew assembleLibraries
./gradlew assembleLibrariesDebug assembleLibrariesRelease
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's maybe still keep assembleLibraries? it is for the local run, without the agent, so we can run everything at once.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xgouchet xgouchet force-pushed the xgouchet/RUM-3861/oom_ci branch 2 times, most recently from 7bf4beb to 7213c49 Compare April 16, 2024 07:11
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

Merging #1986 (c85c004) into develop (ebf7542) will increase coverage by 0.05%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1986      +/-   ##
===========================================
+ Coverage    83.68%   83.73%   +0.05%     
===========================================
  Files          487      487              
  Lines        17736    17726      -10     
  Branches      2663     2662       -1     
===========================================
  Hits         14842    14842              
+ Misses        2167     2160       -7     
+ Partials       727      724       -3     

see 28 files with indirect coverage changes

@xgouchet xgouchet requested a review from 0xnm April 16, 2024 09:31
.gitlab-ci.yml Outdated Show resolved Hide resolved
.codecov.yml Outdated Show resolved Hide resolved
@xgouchet xgouchet merged commit a82bc05 into develop Apr 16, 2024
22 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-3861/oom_ci branch April 16, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants