Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Detekt API version used to 1.23.0 #1988

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Apr 15, 2024

What does this PR do?

I noticed some Kotlin 1.7 artifacts downloaded for the test classpath and they were coming from Detekt 1.22.0.

This PR updates Detekt to 1.23.0 to be better aligned with the version we use for the checks (1.23.4) and to stop Kotlin 1.7 artifacts being downloaded.

Detekt 1.23.4 is not used because it will bring Kotlin 1.9, this is not what we want.

Detekt changelog is here.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners April 15, 2024 12:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Merging #1988 (b658564) into develop (ebf7542) will decrease coverage by 0.07%.
Report is 19 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1988      +/-   ##
===========================================
- Coverage    83.68%   83.61%   -0.07%     
===========================================
  Files          487      487              
  Lines        17736    17741       +5     
  Branches      2663     2663              
===========================================
- Hits         14842    14834       -8     
- Misses        2167     2180      +13     
  Partials       727      727              

see 27 files with indirect coverage changes

@0xnm 0xnm force-pushed the nogorodnikov/update-detekt-api-version branch from 1dec6d4 to 0b4ddad Compare April 15, 2024 12:34
@xgouchet
Copy link
Collaborator

Note

We also need to update the shared pipeline to 1.23.0 in dd-source

@0xnm
Copy link
Contributor Author

0xnm commented Apr 16, 2024

@xgouchet It is 1.23.4 there in the latest version. Or you mean something else?

Anyway, with this PR tests are passing on macOS, but failing in the CI (Linux) container, so I probably keep this PR on hold for now.

@0xnm 0xnm force-pushed the nogorodnikov/update-detekt-api-version branch 3 times, most recently from c2afaad to d0d444f Compare April 18, 2024 10:28
@0xnm 0xnm force-pushed the nogorodnikov/update-detekt-api-version branch from d0d444f to b658564 Compare April 18, 2024 10:34
@0xnm 0xnm merged commit 86a9447 into develop Apr 18, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/update-detekt-api-version branch April 18, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants