Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3597: Start sending batches immediately after feature is initialized #1991

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Apr 17, 2024

What does this PR do?

This change removes initial delay for start sending batches, now they the first upload will be triggered right after the feature is initialized instead of waiting for some delay.

This allows to submit more data in case if application is crashing early.

The downside is that there is a chance that first batch uploaded won't be sent to the batch upload metrics telemetry, because RUM monitor may be not ready yet, but this is acceptable.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners April 17, 2024 09:04
@0xnm 0xnm force-pushed the nogorodnikov/rum-3597/start-sending-batches-immediately-after-feature-initialization branch from 4371143 to 8998bda Compare April 17, 2024 13:41
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Merging #1991 (8998bda) into develop (71dab01) will increase coverage by 0.10%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head 8998bda differs from pull request most recent head ae36cdc. Consider uploading reports for the commit ae36cdc to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1991      +/-   ##
===========================================
+ Coverage    83.64%   83.74%   +0.10%     
===========================================
  Files          488      488              
  Lines        17771    17773       +2     
  Branches      2666     2666              
===========================================
+ Hits         14863    14883      +20     
+ Misses        2183     2167      -16     
+ Partials       725      723       -2     
Files Coverage Δ
...in/com/datadog/android/core/internal/SdkFeature.kt 89.10% <100.00%> (+0.07%) ⬆️
...id/core/internal/data/upload/DataUploadRunnable.kt 96.83% <100.00%> (+0.05%) ⬆️
...d/core/internal/data/upload/DataUploadScheduler.kt 100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

@0xnm 0xnm force-pushed the nogorodnikov/rum-3597/start-sending-batches-immediately-after-feature-initialization branch from 8998bda to ae36cdc Compare April 17, 2024 14:33
@0xnm 0xnm merged commit 8600b0d into develop Apr 17, 2024
22 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-3597/start-sending-batches-immediately-after-feature-initialization branch April 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants