Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of deprecated TestConfig constructor #1999

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Apr 18, 2024

What does this PR do?

These usages were added in #1996. This PR fixes that.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners April 18, 2024 14:10
@codecov-commenter
Copy link

Codecov Report

Merging #1999 (26dd5af) into develop (86a9447) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1999      +/-   ##
===========================================
+ Coverage    83.69%   83.76%   +0.07%     
===========================================
  Files          488      488              
  Lines        17743    17772      +29     
  Branches      2661     2666       +5     
===========================================
+ Hits         14849    14886      +37     
+ Misses        2174     2169       -5     
+ Partials       720      717       -3     

see 24 files with indirect coverage changes

@0xnm 0xnm merged commit 398e380 into develop Apr 18, 2024
22 checks passed
@0xnm 0xnm deleted the nogorodnikov/remove-deprecated-test-config-usage branch April 18, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants