-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some unused IAST/CI Visibility classes #2000
Merged
0xnm
merged 1 commit into
feature/otel-support
from
nogorodnikov/otel-remove-unused-iast-ci-visibility-classes
Apr 19, 2024
Merged
Remove some unused IAST/CI Visibility classes #2000
0xnm
merged 1 commit into
feature/otel-support
from
nogorodnikov/otel-remove-unused-iast-ci-visibility-classes
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
previously approved these changes
Apr 18, 2024
Thanks a lot for the help. Can you please rebase it on top of my current branch: mconstantin/rum-3389/add-trace-otel-feature-integration-tests, this way you can have the integration tests in place to verify. |
020965e
to
ebcfb0f
Compare
xgouchet
previously approved these changes
Apr 18, 2024
989c4e0
to
0a423fe
Compare
Base automatically changed from
mconstantin/rum-3389/add-trace-otel-feature-integration-tests
to
feature/otel-support
April 19, 2024 07:40
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/otel-support #2000 +/- ##
========================================================
+ Coverage 60.35% 63.19% +2.84%
========================================================
Files 808 753 -55
Lines 30223 28501 -1722
Branches 4951 4677 -274
========================================================
- Hits 18241 18010 -231
+ Misses 10761 9303 -1458
+ Partials 1221 1188 -33
|
ebcfb0f
to
4dc4063
Compare
mariusc83
approved these changes
Apr 19, 2024
xgouchet
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes some unused IAST/CI Visibility classes.
Review checklist (to be filled by reviewers)