Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused IAST/CI Visibility classes #2000

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Apr 18, 2024

What does this PR do?

This PR removes some unused IAST/CI Visibility classes.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners April 18, 2024 14:51
xgouchet
xgouchet previously approved these changes Apr 18, 2024
@mariusc83
Copy link
Collaborator

Thanks a lot for the help. Can you please rebase it on top of my current branch: mconstantin/rum-3389/add-trace-otel-feature-integration-tests, this way you can have the integration tests in place to verify.

@0xnm 0xnm force-pushed the nogorodnikov/otel-remove-unused-iast-ci-visibility-classes branch from 020965e to ebcfb0f Compare April 18, 2024 15:05
@0xnm 0xnm changed the base branch from feature/otel-support to mconstantin/rum-3389/add-trace-otel-feature-integration-tests April 18, 2024 15:06
xgouchet
xgouchet previously approved these changes Apr 18, 2024
@mariusc83 mariusc83 force-pushed the mconstantin/rum-3389/add-trace-otel-feature-integration-tests branch from 989c4e0 to 0a423fe Compare April 18, 2024 15:45
Base automatically changed from mconstantin/rum-3389/add-trace-otel-feature-integration-tests to feature/otel-support April 19, 2024 07:40
@mariusc83 mariusc83 dismissed xgouchet’s stale review April 19, 2024 07:40

The base branch was changed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Merging #2000 (4dc4063) into feature/otel-support (3bd8514) will increase coverage by 2.84%.
The diff coverage is n/a.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/otel-support    #2000      +/-   ##
========================================================
+ Coverage                 60.35%   63.19%   +2.84%     
========================================================
  Files                       808      753      -55     
  Lines                     30223    28501    -1722     
  Branches                   4951     4677     -274     
========================================================
- Hits                      18241    18010     -231     
+ Misses                    10761     9303    -1458     
+ Partials                   1221     1188      -33     
Files Coverage Δ
...ce/src/main/java/com/datadog/trace/api/Config.java 49.09% <ø> (-2.45%) ⬇️
...java/com/datadog/trace/api/InstrumenterConfig.java 53.33% <ø> (-0.45%) ⬇️
...c/main/java/com/datadog/trace/core/CoreTracer.java 64.53% <ø> (+0.64%) ⬆️
...main/java/com/datadog/trace/core/StatusLogger.java 2.44% <ø> (+0.23%) ⬆️

... and 37 files with indirect coverage changes

@0xnm 0xnm force-pushed the nogorodnikov/otel-remove-unused-iast-ci-visibility-classes branch from ebcfb0f to 4dc4063 Compare April 19, 2024 07:44
@0xnm 0xnm merged commit 9a7e978 into feature/otel-support Apr 19, 2024
25 checks passed
@0xnm 0xnm deleted the nogorodnikov/otel-remove-unused-iast-ci-visibility-classes branch April 19, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants