-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-1151 Use the Local first-party host detector #515
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.8.0 #515 +/- ##
===================================================
+ Coverage 89.43% 89.69% +0.26%
- Complexity 1372 1374 +2
===================================================
Files 160 160
Lines 4685 4676 -9
Branches 530 532 +2
===================================================
+ Hits 4190 4194 +4
+ Misses 321 307 -14
- Partials 174 175 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to update the Sample App too by adding the tracedHosts to RumInterceptor or you want to do this in a second PR ?
@@ -102,7 +102,7 @@ internal object CoreFeature { | |||
initializeClockSync(appContext) | |||
setupInfoProviders(appContext, consent) | |||
setupOkHttpClient(configuration.needsClearTextHttp) | |||
firstPartyHostDetector = FirstPartyHostDetector(configuration.firstPartyHosts) | |||
firstPartyHostDetector.addKnownHosts(configuration.firstPartyHosts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I guess this is the main reason of the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly this one but sometimes our clients can have multiple OkHttp clients and they want to be able to configure separated traced hosts for them. Having this in mind we need a global traced hosts entry + the possibility to add custom traced hosts/RumInterceptor and for that we were using the localFirstPartyHostDetector
which was not used anymore.
…ated before SDK config
f895eba
to
cf6fe44
Compare
What does this PR do?
Ensure the local first party hosts provided in the OkHttp Interceptors are actually used.
Fixes #513
Additional Notes
We also removed the
warnDeprecated
calls that existed and weren't not removed in the un-deprecation of the related constructors