RUMM-2170 Create Feature configuration interfaces #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
approved these changes
May 19, 2022
| * Contains the storage configuration for an [FeatureScope] instance. | ||
| * @property maxItemSize the maximum size (in bytes) for a single item in a batch | ||
| * @property maxItemPerBatch the maximum number of individual items in a batch | ||
| * @property maxBatchSize the maximum size of a complete batch |
There was a problem hiding this comment.
Suggested change
| * @property maxBatchSize the maximum size of a complete batch | |
| * @property maxBatchSize the maximum size (in bytes) of a complete batch |
| * @property maxItemSize the maximum size (in bytes) for a single item in a batch | ||
| * @property maxItemPerBatch the maximum number of individual items in a batch | ||
| * @property maxBatchSize the maximum size of a complete batch | ||
| * @property oldBatchThreshold the duration after which a batch is considered too old to be |
| package com.datadog.android.v2.api | ||
|
|
||
| /** | ||
| * Describes the format of a paylod for an instance of [SDKFeature]. |
There was a problem hiding this comment.
Suggested change
| * Describes the format of a paylod for an instance of [SDKFeature]. | |
| * Describes the format of a payload for an instance of [SDKFeature]. |
xgouchet
force-pushed
the
xgouchet/RUMM-2170/SDK_Feature_Configuration
branch
from
1e4e34c
to
3349370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create the interfaces for the SDKv2 features configuration