RUMM-2336: Bring tests back #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
force-pushed
the
nogorodnikov/rumm-2236/bring-unit-tests-back
branch
from
116c0d5
to
1188e20
Compare
mariusc83
reviewed
Jul 8, 2022
| @@ -70,7 +70,8 @@ internal class SpanForgeryFactory : ForgeryFactory<DDSpan> { | |||
| } | |||
|
|
|||
| companion object { | |||
| val TEST_TRACER = AndroidTracer.Builder().build() | |||
| // TODO remove service call once Tracer gets default value | |||
There was a problem hiding this comment.
don't you need a ticket here ?
0xnm
force-pushed
the
nogorodnikov/rumm-2236/bring-unit-tests-back
branch
2 times, most recently
from
94981fd
to
90f2da5
Compare
0xnm
force-pushed
the
nogorodnikov/rumm-2236/bring-unit-tests-back
branch
from
90f2da5
to
d5ae1b9
Compare
Codecov Report
@@ Coverage Diff @@
## nogorodnikov/rumm-2204/data-is-written-in-sdk-specific-location #977 +/- ##
==================================================================================================
Coverage ? 82.42%
==================================================================================================
Files ? 291
Lines ? 9482
Branches ? 1573
==================================================================================================
Hits ? 7815
Misses ? 1199
Partials ? 468 |
Base automatically changed from
nogorodnikov/rumm-2204/data-is-written-in-sdk-specific-location
to
feature/sdkv2
July 11, 2022 15:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change fixes the tests which were broken before. This will simplify the future development on the
sdkv2branch.Review checklist (to be filled by reviewers)