Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RumFeature#context instead of CoreFeature#contextRef in RumFeature #982

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Jul 12, 2022

What does this PR do?

Tiny change to use RumFeature#context which is set during the initialization instead of CoreFeature#contextRef: WeakReference(which may disappear).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner July 12, 2022 13:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #982 (ef707b2) into feature/sdkv2 (384e618) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           feature/sdkv2     #982      +/-   ##
=================================================
- Coverage          82.67%   82.66%   -0.01%     
=================================================
  Files                296      296              
  Lines               9777     9777              
  Branches            1617     1617              
=================================================
- Hits                8083     8082       -1     
- Misses              1210     1211       +1     
  Partials             484      484              
Impacted Files Coverage Δ
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.16% <100.00%> (ø)
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (-4.90%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 90.32% <0.00%> (-1.61%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 86.70% <0.00%> (-0.53%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 56.07% <0.00%> (ø)
...ain/java/com/datadog/opentracing/PendingTrace.java 60.34% <0.00%> (+1.72%) ⬆️
...tadog/android/core/internal/net/CurlInterceptor.kt 83.33% <0.00%> (+2.38%) ⬆️
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 100.00% <0.00%> (+4.08%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 100.00% <0.00%> (+25.00%) ⬆️

@0xnm 0xnm merged commit 1532e98 into feature/sdkv2 Jul 12, 2022
@0xnm 0xnm deleted the nogorodnikov/use-direct-context-in-rum-feature branch July 12, 2022 14:54
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants