-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fix in the PokoGenerator tool #989
Conversation
@@ -124,7 +124,7 @@ public sealed class Animal { | |||
asBird, | |||
).firstOrNull { it != null } | |||
if (result == null) { | |||
val message = "Unable to parse json into one of type Animal\n" + | |||
val message = "Unable to parse json into one of type \n" + "Animal\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need an additional line break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in some of the schemas for Session Replay we have longer class names and it breaks when Kotlin Poet wraps the line.
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #989 +/- ##
=================================================
+ Coverage 82.63% 82.83% +0.20%
=================================================
Files 296 295 -1
Lines 9777 9714 -63
Branches 1617 1590 -27
=================================================
- Hits 8079 8046 -33
+ Misses 1214 1188 -26
+ Partials 484 480 -4
|
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)