Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1555 Update default tracing headers to datadog + W3C (tracecontext) #1529

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

maciejburda
Copy link
Contributor

What and why?

Adds W3C tracecontext to default configuration along with datadog headers.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maciejburda maciejburda requested a review from a team as a code owner October 25, 2023 16:54
@maciejburda maciejburda changed the title RUM-1555 Default tracing update RUM-1555 Update default tracing headers to datadog + W3C (tracecontext) Oct 25, 2023
@maciejburda
Copy link
Contributor Author

@ganeshnj Do you think we should quite in the CHANGELOG.md?

@maciejburda maciejburda force-pushed the maciey/RUM-1555-default-tracing-update branch from c8c417c to 65f7ac1 Compare October 25, 2023 16:55
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 25, 2023

Datadog Report

Branch report: maciey/RUM-1555-default-tracing-update
Commit report: 65f7ac1

dd-sdk-ios: 0 Failed, 0 New Flaky, 2652 Passed, 0 Skipped, 10m 49.78s Wall Time

@ganeshnj
Copy link
Contributor

@ganeshnj Do you think we should quite in the CHANGELOG.md?

Yes we should. Let's keep it consistent across the board.

https://github.com/DataDog/dd-sdk-flutter/pull/501/files

  • Change default tracing headers for first party hosts to use both Datadog headers and W3C tracecontext headers.

ganeshnj
ganeshnj previously approved these changes Oct 26, 2023
xgouchet
xgouchet previously approved these changes Oct 26, 2023
Copy link
Collaborator

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌. However, we change default behaviour, so we must update public API comments with new configuration. The change we introduce here impacts these two APIs:

ganeshnj
ganeshnj previously approved these changes Oct 26, 2023
ncreated
ncreated previously approved these changes Oct 26, 2023
Copy link
Collaborator

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maciejburda maciejburda merged commit 72c57c5 into develop Oct 27, 2023
8 checks passed
@maciejburda maciejburda deleted the maciey/RUM-1555-default-tracing-update branch October 27, 2023 08:06
@maxep maxep mentioned this pull request Nov 8, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants