Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2154 Enable resource endpoint #1592

Merged
merged 29 commits into from
Feb 14, 2024

Conversation

maciejburda
Copy link
Contributor

@maciejburda maciejburda commented Dec 15, 2023

What and why?

Enables resource recording using resource endpoint and deprecates and disables base64 solution.
Along with this, we conducted some E2E tests and fixed some minor bugs that we spotted.

Also, there were a few updates to snapshot tests, that cover new ways of getting and rendering image data.

How?

Code was prepared in past PRs. It's mostly achieved by injecting ResourceProcessor.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maciejburda
Copy link
Contributor Author

maciejburda commented Dec 15, 2023

To be rebased on develop after #1585 is merged and prod backend is ready

@maciejburda maciejburda force-pushed the maciey/RUM-2154-enable-resource-endpoint branch 3 times, most recently from cb1d464 to 7fb41f7 Compare January 3, 2024 11:36
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 3, 2024

Datadog Report

Branch report: maciey/RUM-2154-enable-resource-endpoint
Commit report: 962c80e
Test service: dd-sdk-ios

❌ 1 Failed (0 Known Flaky), 2722 Passed, 0 Skipped, 6m 49.62s Wall Time
🔻 Test Sessions change in coverage: 8 decreased, 5 increased

❌ Failed Tests (1)

  • testItRemovedDuplicates - ResourceProcessorTests - Details

    Expand for error
     Assertion Failure at ResourceProcessorTests.swift:80: XCTAssertEqual failed: ("2") is not equal to ("1")
    

🔻 Code Coverage Decreases vs Default Branch (8)

This report shows up to 5 code coverage decreases.

  • test DatadogLogsTests tvOS 44.77% (-0.18%) - Details
  • test DatadogLogsTests iOS 44.72% (-0.17%) - Details
  • test DatadogCrashReportingTests tvOS 28.88% (-0.17%) - Details
  • test DatadogCrashReportingTests iOS 28.84% (-0.17%) - Details
  • test DatadogRUMTests iOS 79.26% (-0.15%) - Details

@maciejburda maciejburda force-pushed the maciey/RUM-2154-enable-resource-endpoint branch 3 times, most recently from da778d5 to 16e5208 Compare January 10, 2024 16:30
@maciejburda maciejburda marked this pull request as ready for review January 10, 2024 16:30
@maciejburda maciejburda requested review from a team as code owners January 10, 2024 16:30
@maciejburda
Copy link
Contributor Author

Awaiting for backend to be deployed.

@maciejburda maciejburda force-pushed the maciey/RUM-2154-enable-resource-endpoint branch 3 times, most recently from 4f97709 to ba44d2f Compare January 17, 2024 16:01
Copy link
Collaborator

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked SR product changes, but modifications in sr-snapshots CLI and SRSnapshotTests project look fine with one remark 👌. Glad we extended it with the support to SR Resources - nice 💪.

Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I have left a couple of blocking points

@maciejburda
Copy link
Contributor Author

Thanks for the review @maxep

I think I managed to resolve all the comments.

Also simplified threading by reusing the same queue in both processors.

ncreated
ncreated previously approved these changes Feb 8, 2024
Copy link
Collaborator

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok 👌, I left suggestions on adding tests coverage

maxep
maxep previously approved these changes Feb 9, 2024
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@maciejburda maciejburda dismissed stale reviews from maxep and ncreated via 391d63f February 9, 2024 12:55
Copy link
Collaborator

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Can we have this PR properly described, not leaving blank PR template? We won't know what was the scope of this change.

@maciejburda maciejburda merged commit b5417c3 into develop Feb 14, 2024
8 checks passed
@maciejburda maciejburda deleted the maciey/RUM-2154-enable-resource-endpoint branch February 14, 2024 12:14
@maciejburda maciejburda mentioned this pull request Mar 19, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants