Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2746 feat: Add additional status codes as retryable #1639

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

ncreated
Copy link
Collaborator

@ncreated ncreated commented Jan 19, 2024

What and why?

📦 This PR adds following HTTP status codes to the list of retryable codes. This is to prevent data loss upon receiving them from Intake:

  • 502 - bad gateway
  • 504 - gateway timeout
  • 507 - insufficient storage

Counterpart of: DataDog/dd-sdk-android#1819

How?

Added these codes to HTTPResponseStatusCode. We use fuzzy testing in this part, so no extra tests added, but the configuration of existing ones is updated.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this Jan 19, 2024
@ncreated ncreated marked this pull request as ready for review January 19, 2024 10:29
@ncreated ncreated requested review from a team as code owners January 19, 2024 10:30
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 19, 2024

Datadog Report

Branch report: ncreated/RUM-2745/include-additional-retry-codes
Commit report: 777dc78
Test service: dd-sdk-ios

✅ 0 Failed, 2483 Passed, 0 Skipped, 5m 28.47s Wall Time
🔻 Test Sessions change in coverage: 7 decreased, 6 increased

🔻 Code Coverage Decreases vs Default Branch (7)

This report shows up to 5 code coverage decreases.

  • test DatadogCrashReportingTests tvOS 28.96% (Δ-0.09%) - Details
  • test DatadogWebViewTrackingTests iOS 23.00% (Δ-0.08%) - Details
  • test DatadogCrashReportingTests iOS 28.95% (Δ-0.06%) - Details
  • test DatadogInternalTests tvOS 81.21% (Δ-0.05%) - Details
  • test DatadogLogsTests tvOS 44.90% (Δ-0.05%) - Details

@ncreated ncreated merged commit abdbc70 into develop Jan 23, 2024
6 checks passed
@ncreated ncreated deleted the ncreated/RUM-2745/include-additional-retry-codes branch January 23, 2024 09:36
@ncreated ncreated mentioned this pull request Jan 25, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants