Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSPrivacyCollectedDataTypes #1656

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add NSPrivacyCollectedDataTypes #1656

merged 2 commits into from
Feb 6, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Feb 6, 2024

What and why?

Missing the NSPrivacyCollectedDataTypes prevents from generating the Privacy Report.

Resolve #1655

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep requested review from a team as code owners February 6, 2024 11:00
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 6, 2024

Datadog Report

Branch report: maxep/fix-privacy-manifest
Commit report: 5d5491f
Test service: dd-sdk-ios

✅ 0 Failed, 2503 Passed, 0 Skipped, 6m 22.31s Wall Time
🔻 Test Sessions change in coverage: 8 decreased, 4 increased, 1 no change

🔻 Code Coverage Decreases vs Default Branch (8)

This report shows up to 5 code coverage decreases.

  • test DatadogLogsTests tvOS 44.59% (-0.36%) - Details
  • test DatadogLogsTests iOS 44.55% (-0.34%) - Details
  • test DatadogWebViewTrackingTests iOS 22.81% (-0.27%) - Details
  • test DatadogCrashReportingTests tvOS 28.79% (-0.26%) - Details
  • test DatadogCrashReportingTests iOS 28.75% (-0.26%) - Details

@maxep maxep merged commit 0202aac into develop Feb 6, 2024
6 checks passed
@maxep maxep deleted the maxep/fix-privacy-manifest branch February 6, 2024 12:20
@maxep maxep mentioned this pull request Feb 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Missing Properties] Privacy Manifest, unable to generate privacy report
2 participants