Fix privacy manifest collision #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 2491 Passed, 0 Skipped, 5m 22.94s Wall Time 🔻 Code Coverage Decreases vs Default Branch (8)
|
maxep
force-pushed
the
maxep/fix-privacy-manifest
branch
from
bc3c136
to
b17e96a
Compare
maxep
force-pushed
the
maxep/fix-privacy-manifest
branch
from
b17e96a
to
8ab394d
Compare
ncreated
reviewed
Feb 9, 2024
Comment on lines
-44
to
-49
| // DDURLSessionDelegate APIs must be visible: | ||
| _ = DDURLSessionDelegate() | ||
| _ = DatadogURLSessionDelegate() | ||
| class CustomDelegate: NSObject, __URLSessionDelegateProviding { | ||
| var ddURLSessionDelegate: DatadogURLSessionDelegate { DatadogURLSessionDelegate() } | ||
| } |
There was a problem hiding this comment.
q/ Why this removal? Due to deprecation warnings treated as build error?
There was a problem hiding this comment.
Yes, and because it's deprecated anyway.
ncreated
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
When using static linkage in CocoaPods with
use_frameworks! :linkage => :static. The pod's resource gets copied at root of the app bundle, resulting in collision with the app'sPrivacyInfo.xcprivacy.Resolve #1665
How?
Use
resource_bundleto keep thePrivacyInfo.xcprivacyin it own bundle.The smoke tests apps now all define privacy-manifest to catch any collision.
Review checklist
Custom CI job configuration (optional)
tools/