RUM-3461 refactor: Replace core dependency in RUM with FeatureScope
#1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by removing abitrary `core` reference passing
ncreated
commented
Mar 26, 2024
Comment on lines
-29
to
+19
| let core = PassthroughCoreMock( | ||
| bypassConsentExpectation: expectation(description: "Send Event Bypass Consent"), | ||
| messageReceiver: CrashReportReceiver.mockAny() | ||
| ) | ||
| let receiver: CrashReportReceiver = .mockWith(featureScope: featureScope) |
There was a problem hiding this comment.
This is a common pattern in this PR. We change from testing message receivers as part of mocked core to testing them as individual units. 🧽 🧹
Datadog ReportBranch report: ✅ 0 Failed, 2897 Passed, 0 Skipped, 11m 35.08s Wall Time 🔻 Code Coverage Decreases vs Default Branch (12)
|
maxep
approved these changes
Mar 27, 2024
ncreated
deleted the
ncreated/RUM-3461/refactor-rum-to-depend-on-feature-scope
branch
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 Utilizing the change from #1744, this PR updates the whole RUM to depend on
FeatureScopeinterface rather thanDatadogCoreProtocoldirectly.This will be leveraged in fatal App Hangs monitoring, where
AppHangObserverwill take a dependency onFeatureScopeto access DataStore, Event Write Context and Telemetry.How?
With
FeatureScopebeing available during RUM feature registration (#1744), it is now injected into all downstream components in RUM including theMonitorand all message receivers.Review checklist
Custom CI job configuration (optional)
tools/