RUMM-1350 let customer set up a Proxy for data upload #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
requested changes
Sep 2, 2021
Comment on lines
255
to
261
| let proxyConfiguration: [AnyHashable: Any] = [ | ||
| kCFNetworkProxiesHTTPEnable as AnyHashable: true, | ||
| kCFNetworkProxiesHTTPPort as AnyHashable: 123, | ||
| kCFNetworkProxiesHTTPProxy as AnyHashable: "www.example.com", | ||
| kCFProxyUsernameKey as AnyHashable: "proxyuser", | ||
| kCFProxyPasswordKey as AnyHashable: "proxypass", | ||
| ] |
There was a problem hiding this comment.
All casting as AnyHashable are redundant, it is enforced by the dictionary type.
It also valid for all getter in further assertions.
Suggested change
| let proxyConfiguration: [AnyHashable: Any] = [ | |
| kCFNetworkProxiesHTTPEnable as AnyHashable: true, | |
| kCFNetworkProxiesHTTPPort as AnyHashable: 123, | |
| kCFNetworkProxiesHTTPProxy as AnyHashable: "www.example.com", | |
| kCFProxyUsernameKey as AnyHashable: "proxyuser", | |
| kCFProxyPasswordKey as AnyHashable: "proxypass", | |
| ] | |
| let proxyConfiguration: [AnyHashable: Any] = [ | |
| kCFNetworkProxiesHTTPEnable: true, | |
| kCFNetworkProxiesHTTPPort: 123, | |
| kCFNetworkProxiesHTTPProxy: "www.example.com", | |
| kCFProxyUsernameKey: "proxyuser", | |
| kCFProxyPasswordKey: "proxypass", | |
| ] |
| ] | ||
| let configuration = try createConfiguration(proxyConfiguration: proxyConfiguration) | ||
|
|
||
| XCTAssertEqual(configuration.common.proxyConfiguration?[kCFNetworkProxiesHTTPEnable as AnyHashable] as? Bool, true) |
There was a problem hiding this comment.
Suggested change
| XCTAssertEqual(configuration.common.proxyConfiguration?[kCFNetworkProxiesHTTPEnable as AnyHashable] as? Bool, true) | |
| XCTAssertEqual(configuration.common.proxyConfiguration?[kCFNetworkProxiesHTTPEnable] as? Bool, true) |
| @@ -180,6 +180,13 @@ class DDConfigurationTests: XCTestCase { | |||
| objcBuilder.set(additionalConfiguration: ["foo": 42, "bar": "something"]) | |||
| XCTAssertEqual(objcBuilder.build().sdkConfiguration.additionalConfiguration["foo"] as? Int, 42) | |||
| XCTAssertEqual(objcBuilder.build().sdkConfiguration.additionalConfiguration["bar"] as? String, "something") | |||
|
|
|||
| objcBuilder.set(proxyConfiguration: [kCFNetworkProxiesHTTPEnable as AnyHashable: true, kCFNetworkProxiesHTTPPort as AnyHashable: 123, kCFNetworkProxiesHTTPProxy as AnyHashable: "www.example.com", kCFProxyUsernameKey as AnyHashable: "proxyuser", kCFProxyPasswordKey as AnyHashable: "proxypass" ]) | |||
There was a problem hiding this comment.
/nit
Suggested change
| objcBuilder.set(proxyConfiguration: [kCFNetworkProxiesHTTPEnable as AnyHashable: true, kCFNetworkProxiesHTTPPort as AnyHashable: 123, kCFNetworkProxiesHTTPProxy as AnyHashable: "www.example.com", kCFProxyUsernameKey as AnyHashable: "proxyuser", kCFProxyPasswordKey as AnyHashable: "proxypass" ]) | |
| objcBuilder.set(proxyConfiguration: [ | |
| kCFNetworkProxiesHTTPEnable: true, | |
| kCFNetworkProxiesHTTPPort: 123, | |
| kCFNetworkProxiesHTTPProxy: "www.example.com", | |
| kCFProxyUsernameKey: "proxyuser", | |
| kCFProxyPasswordKey: "proxypass" | |
| ]) |
ncreated
approved these changes
Sep 3, 2021
sarina-dd
reviewed
Sep 3, 2021
sarina-dd
approved these changes
Sep 3, 2021
Co-authored-by: Sarina Bloodgood <57639676+sarina-dd@users.noreply.github.com>
xgouchet
force-pushed
the
xgouchet/RUMM-1350/proxy
branch
from
226ca52
to
22e44de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Let a customer setup a custom Proxy for data intake.
How?
A new method let's the customer provide the proxy configuration dictionary that will be forwarded to the HttpClient to create the
URLSession.Review checklist