Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Datadog SDK is initialized on the main thread. Fixes #198 #204

Merged
merged 2 commits into from
May 30, 2022
Merged

Make sure Datadog SDK is initialized on the main thread. Fixes #198 #204

merged 2 commits into from
May 30, 2022

Conversation

cltnschlosser
Copy link
Contributor

What does this PR do?

Makes sure the the Datadog SDK is initialized on the main thread

Motivation

Fixes #198

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests ()
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@cltnschlosser cltnschlosser requested a review from a team as a code owner May 27, 2022 17:56
xgouchet
xgouchet approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for additional reviews

@louiszawadzki louiszawadzki merged commit 8d99165 into DataDog:develop May 30, 2022
@cltnschlosser cltnschlosser deleted the cs_main-thread-warning branch May 30, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep left review comments

@xgouchet xgouchet xgouchet approved these changes

@mariusc83 mariusc83 mariusc83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS: UI API called from background thread - UIApplication.applicationState must be used from main thread only
5 participants
@cltnschlosser @xgouchet @mariusc83 @maxep @louiszawadzki