Bump iOS bridge versions to 0.5.4 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiszawadzki
changed the title
louiszawadzki
changed the title
louiszawadzki
force-pushed
the
louiszawadzki/bump-bridge-versions
branch
from
a97640e
to
27777c8
Compare
0xnm
approved these changes
May 31, 2022
louiszawadzki
commented
May 31, 2022
| @@ -2,7 +2,6 @@ require_relative '../node_modules/react-native/scripts/react_native_pods' | |||
| require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules' | |||
|
|
|||
| platform :ios, '11.0' | |||
| use_frameworks! | |||
There was a problem hiding this comment.
use_frameworks! is not supported by the latest version of the bridge
louiszawadzki
commented
May 31, 2022
| @@ -3784,7 +3784,16 @@ prompts@^2.4.0: | |||
| kleur "^3.0.3" | |||
| sisteransi "^1.0.5" | |||
|
|
|||
| prop-types@15.x.x, prop-types@^15.7.2: | |||
| prop-types@15.x.x: | |||
There was a problem hiding this comment.
I need to understand why some changes happened here
There was a problem hiding this comment.
probably something missed in a previous PR
louiszawadzki
commented
May 31, 2022
| @@ -202,90 +202,22 @@ | |||
| shellPath = /bin/sh; | |||
| shellScript = "export NODE_BINARY=node\n../node_modules/react-native/scripts/react-native-xcode.sh"; | |||
| }; | |||
| 0F5DD2465E82C89D1BBC8144 /* [CP] Embed Pods Frameworks */ = { | |||
| 1C1ED57B55ECBF1430A95142 /* [CP] Copy Pods Resources */ = { | |||
There was a problem hiding this comment.
I need to understand why some changes happened here
There was a problem hiding this comment.
This is because we removed !use_frameworks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)