Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape special characters in first party hosts regex #235

Merged
merged 1 commit into from Aug 3, 2022
Merged

Escape special characters in first party hosts regex #235

merged 1 commit into from Aug 3, 2022

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

Escape special characters like . in first party hosts regex

Motivation

Fix warnings that were spotted by code scanning

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner July 29, 2022 15:54
@louiszawadzki louiszawadzki merged commit 708eb3a into develop Aug 3, 2022
@louiszawadzki louiszawadzki deleted the louiszawadzki/fix-regex-builder branch August 3, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgouchet xgouchet xgouchet approved these changes

@plousada plousada plousada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louiszawadzki @xgouchet @plousada