Add logs mapper #374
Merged
Add logs mapper #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 9, 2023 11:00
louiszawadzki
force-pushed
the
louiszawadzki/rumm-2585/add-logs-mapper
branch
3 times, most recently
from
e710ca4
to
0df95e8
Compare
louiszawadzki
commented
Jan 11, 2023
louiszawadzki
force-pushed
the
louiszawadzki/rumm-2585/add-logs-mapper
branch
2 times, most recently
from
cccbc04
to
3f0edc8
Compare
louiszawadzki
force-pushed
the
louiszawadzki/rumm-2585/add-logs-mapper
branch
2 times, most recently
from
7e896cc
to
b9ed21c
Compare
louiszawadzki
commented
Jan 12, 2023
fuzzybinary
reviewed
Jan 12, 2023
fuzzybinary
approved these changes
Jan 12, 2023
added 2 commits
January 13, 2023 10:22
louiszawadzki
force-pushed
the
louiszawadzki/rumm-2585/add-logs-mapper
branch
from
b9ed21c
to
c4ab3b9
Compare
xgouchet
reviewed
Jan 13, 2023
| InternalLog.log( | ||
| `Setting attributes ${JSON.stringify(attributes)}`, | ||
| SdkVerbosity.DEBUG | ||
| ); | ||
| return DdSdk.setAttributes(attributes); | ||
| await DdSdk.setAttributes(attributes); | ||
| AttributesSingleton.getInstance().setAttributes(attributes); |
There was a problem hiding this comment.
There's no return statement anymore, is this normal?
There was a problem hiding this comment.
Yes it is intended.
We used to return DdSdk.setAttributes(attributes) which itself returns a Promise<void> (promise resolving a value equal to undefined).
Now that we turned the function into an async one, and used await, it also returns a Promise, which in this case is a Promise<void> as we don't return anything.
This would be equivalent to return; or return undefined but the more common syntax is to not use a return statement.
There was a problem hiding this comment.
So using async makes an implicit return Promise, I guess this is knowledge I missed. 😅
xgouchet
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add logs event mapper.
If the event mapper returns
null, it is dropped.Additional Notes
We only allow for modification of
contextandmessagefor now.We can add support for
attributesanduser.extraInfolater, but I don't see much usage of this, so let's wait and see if there is a lot of request before adding this.Review checklist (to be filled by reviewers)