Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support use_frameworks in Podfile #508

Merged
merged 1 commit into from Jul 17, 2023
Merged

Support use_frameworks in Podfile #508

merged 1 commit into from Jul 17, 2023

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

Fix build issues for Podfiles containing use_frameworks!.
I've reused the solution proposed by Cocoapods maintainers here: CocoaPods/CocoaPods#7594 (comment)

Motivation

Fixes #505

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner July 13, 2023 12:46
ncreated
ncreated approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense. It's also widely adopted in many other OSS repos and no one needed to revert it for what I see 👌.

@louiszawadzki louiszawadzki merged commit 7862d2e into develop Jul 17, 2023
4 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/fix-build-issues branch July 17, 2023 08:42
@louiszawadzki louiszawadzki mentioned this pull request Jul 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on IOS build - 1.8.0 sdk version
2 participants
@louiszawadzki @ncreated