Add ticket link in TODO (#58)

* Add ticket link in TODO * Link another TODO to SDS-301
DataDog · May 29, 2024 · 63f9cff · 63f9cff
1 parent c425920
commit 63f9cff
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/sds-go/go/rule.go b/sds-go/go/rule.go
@@ -68,8 +68,8 @@ type ProximityKeywordsConfig struct {
 // RuleMatch stores the matches reported by the core library.
 type RuleMatch struct {
 	RuleIdx uint32
-	// TODO(remy): not implemented yet.
-	Path              string
+	Path    string
+	// TODO(https://datadoghq.atlassian.net/browse/SDS-301): implement replacement type
 	ReplacementType   MatchAction
 	StartIndex        uint32
 	EndIndexExclusive uint32

diff --git a/sds-go/go/scanner.go b/sds-go/go/scanner.go
@@ -270,7 +270,7 @@ func decodeMatchResponse(result *ScanResult, buf *bytes.Buffer) {
 	path := nextString(buf)
 
 	// then a replacement type
-	// TODO(remy): implement me
+	// TODO(https://datadoghq.atlassian.net/browse/SDS-301): implement replacement type
 	//replacementType := nextString(buf)
 	nextString(buf)
 

diff --git a/sds-go/go/scanner_test.go b/sds-go/go/scanner_test.go
@@ -548,6 +548,9 @@ func sortRulesMatch(left, right RuleMatch) bool {
 	if left.EndIndexExclusive > right.EndIndexExclusive {
 		return true
 	}
-	// TODO(remy): path, replacement type
+	if left.Path > right.Path {
+		return true
+	}
+	// TODO(https://datadoghq.atlassian.net/browse/SDS-301): implement replacement type
 	return false
 }