Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise dependencies #5377

Open
thompson-tomo opened this issue Apr 2, 2024 · 4 comments
Open

Optimise dependencies #5377

thompson-tomo opened this issue Apr 2, 2024 · 4 comments

Comments

@thompson-tomo
Copy link

thompson-tomo commented Apr 2, 2024

Is your feature request related to a problem? Please describe.

I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like

Within the Datadog.Trace.OpenTracing package, The System.Net.Http dependency becomes conditional so that it is only added for the older frameworks

Describe alternatives you've considered

Accept the additional dependency

Additional context

n/a

@andrewlock
Copy link
Member

As far as I can see, we don't depend on System.Net.Http, even transitively 🤔 Which NuGet package are you referring to? Datadog.Trace?

@thompson-tomo
Copy link
Author

So Datadog.Trace.OpenTracing depends on System.Net.Http, so I have updated the description.

@andrewlock
Copy link
Member

OK, thanks for the details.

To set expectations, I doubt we will take this approach. The OpenTracing project is archived and considered deprecated at this point. We recommend considering moving to OpenTelemetry instead. We will likely deprecate the Datadog.Trace.OpenTracing package in a future version

thompson-tomo added a commit to thompson-tomo/dd-trace-dotnet that referenced this issue Apr 6, 2024
@thompson-tomo
Copy link
Author

@andrewlock i took a look at this topic & I was able to identify a number of locations where the dependencies can be optimised hence have submitted #5410 to cover these optimisation's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants