Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide warnings for EOL targets (like netcoreapp3.0) #1152

Merged
merged 4 commits into from Jan 21, 2021
Merged

hide warnings for EOL targets (like netcoreapp3.0) #1152

merged 4 commits into from Jan 21, 2021

Conversation

lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Jan 20, 2021 •
edited

Remove the following build warning:

C:\Program Files\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.EolTargetFrameworks.targets(28,5):
warning NETSDK1138: The target framework 'netcoreapp3.0' is out of support and will not receive security updates in the future. 
Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
  • hide warnings for EOL targets (netcoreapp3.0) in test apps by setting CheckEolTargetFramework to false
  • hide same warning for netcoreapp2.0 in the loader project
  • upgrade tools from netcoreapp3.0 to net5.0

@lucaspimentel lucaspimentel added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 20, 2021
@lucaspimentel lucaspimentel marked this pull request as ready for review January 20, 2021 23:41
@lucaspimentel lucaspimentel requested a review from a team as a code owner January 20, 2021 23:41
@lucaspimentel lucaspimentel merged commit c8783b9 into master Jan 21, 2021
@lucaspimentel lucaspimentel deleted the lpimentel/hide-eol-warnings branch January 21, 2021 14:35
@zacharycmontoya zacharycmontoya added this to the 1.23.0 milestone Feb 3, 2021
macrogreg pushed a commit that referenced this pull request Aug 20, 2021
@lucaspimentel
hide build warnings for EOL targets (#1152)
0e05a75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevingosse kevingosse kevingosse approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lucaspimentel @kevingosse @andrewlock @zacharycmontoya