Don't specify patch version for Python install #3970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
area:builds
pierotibou
approved these changes
Mar 29, 2023
Datadog ReportBranch report: ❄️ New Flaky Tests (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3970) - mean (3,041ms) : 2927, 3156
. : milestone, 3041,
master - mean (3,037ms) : 2939, 3134
. : milestone, 3037,
section CallTarget+Inlining+NGEN
This PR (3970) - mean (3,640ms) : 3549, 3731
. : milestone, 3640,
master - mean (3,667ms) : 3578, 3757
. : milestone, 3667,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3970) - mean (3,146ms) : 2996, 3296
. : milestone, 3146,
master - mean (3,183ms) : 3082, 3285
. : milestone, 3183,
section CallTarget+Inlining+NGEN
This PR (3970) - mean (3,521ms) : 3395, 3647
. : milestone, 3521,
master - mean (3,524ms) : 3449, 3599
. : milestone, 3524,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3970) - mean (3,137ms) : 2958, 3315
. : milestone, 3137,
master - mean (3,170ms) : 3055, 3286
. : milestone, 3170,
section CallTarget+Inlining+NGEN
This PR (3970) - mean (3,464ms) : 3388, 3540
. : milestone, 3464,
master - mean (3,481ms) : 3386, 3575
. : milestone, 3481,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3970) - mean (189ms) : 183, 196
. : milestone, 189,
master - mean (187ms) : 183, 192
. : milestone, 187,
section CallTarget+Inlining+NGEN
This PR (3970) - mean (923ms) : 893, 953
. : milestone, 923,
master - mean (920ms) : 892, 948
. : milestone, 920,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3970) - mean (368ms) : 363, 372
. : milestone, 368,
master - mean (366ms) : 360, 373
. : milestone, 366,
section CallTarget+Inlining+NGEN
This PR (3970) - mean (1,054ms) : 1033, 1076
. : milestone, 1054,
master - mean (1,052ms) : 1026, 1077
. : milestone, 1052,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (3970) - mean (355ms) : 348, 363
. : milestone, 355,
master - mean (355ms) : 350, 361
. : milestone, 355,
section CallTarget+Inlining+NGEN
This PR (3970) - mean (1,005ms) : 970, 1040
. : milestone, 1005,
master - mean (1,000ms) : 980, 1019
. : milestone, 1000,
|
Benchmarks Report 🐌Benchmarks for #3970 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (3970) (11.175M) : 0, 11174548
master (11.214M) : 0, 11214167
benchmarks/2.27.0 (10.998M) : 0, 10998184
benchmarks/2.9.0 (11.020M) : 0, 11020152
section Automatic
This PR (3970) (7.900M) : 0, 7900491
master (7.909M) : 0, 7909395
benchmarks/2.27.0 (7.736M) : 0, 7735562
benchmarks/2.9.0 (8.105M) : 0, 8104690
section Trace stats
master (7.808M) : 0, 7808053
benchmarks/2.27.0 (7.913M) : 0, 7912646
section Manual
This PR (3970) (9.844M) : 0, 9844278
master (9.937M) : 0, 9936799
benchmarks/2.27.0 (9.528M) : 0, 9528201
section Manual + Automatic
This PR (3970) (7.542M) : 0, 7541814
master (7.538M) : 0, 7537782
benchmarks/2.27.0 (7.491M) : 0, 7490916
section Version Conflict
master (6.781M) : 0, 6780869
benchmarks/2.27.0 (6.661M) : 0, 6660506
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (3970) (9.589M) : 0, 9588906
master (9.692M) : 0, 9692329
benchmarks/2.27.0 (9.599M) : 0, 9599134
benchmarks/2.9.0 (9.614M) : 0, 9614128
section Automatic
This PR (3970) (6.854M) : 0, 6854063
master (6.815M) : 0, 6814632
benchmarks/2.27.0 (6.789M) : 0, 6789438
section Trace stats
master (6.595M) : 0, 6594527
benchmarks/2.27.0 (6.827M) : 0, 6826820
section Manual
This PR (3970) (8.324M) : 0, 8323977
master (8.507M) : 0, 8507069
benchmarks/2.27.0 (8.300M) : 0, 8299637
section Manual + Automatic
This PR (3970) (6.497M) : 0, 6496615
master (6.411M) : 0, 6410845
benchmarks/2.27.0 (6.502M) : 0, 6502099
section Version Conflict
master (5.882M) : 0, 5882269
benchmarks/2.27.0 (6.035M) : 0, 6034784
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (3970) (9.654M) : 0, 9654021
master (9.711M) : 0, 9710580
benchmarks/2.27.0 (9.381M) : 0, 9381290
benchmarks/2.9.0 (9.607M) : 0, 9607487
section Automatic
This PR (3970) (7.081M) : 0, 7081407
master (7.104M) : 0, 7103701
benchmarks/2.27.0 (6.909M) : 0, 6908772
benchmarks/2.9.0 (6.824M) : 0, 6824125
section Trace stats
master (7.013M) : 0, 7013409
benchmarks/2.27.0 (6.922M) : 0, 6921875
section Manual
This PR (3970) (8.716M) : 0, 8715770
master (8.653M) : 0, 8653158
benchmarks/2.27.0 (8.492M) : 0, 8492158
section Manual + Automatic
This PR (3970) (7.011M) : 0, 7011009
master (6.792M) : 0, 6791663
benchmarks/2.27.0 (6.636M) : 0, 6635899
section Version Conflict
master (6.165M) : 0, 6164545
benchmarks/2.27.0 (5.982M) : 0, 5981512
gantt
title Throughput Linux x64 (ASM) (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (3970) (7.550M) : 0, 7549665
master (7.458M) : 0, 7457513
benchmarks/2.27.0 (7.555M) : 0, 7554510
benchmarks/2.9.0 (7.729M) : 0, 7728646
section No attack
This PR (3970) (2.187M) : 0, 2187098
master (2.148M) : 0, 2147578
benchmarks/2.27.0 (2.159M) : 0, 2159466
benchmarks/2.9.0 (3.254M) : 0, 3253603
section Attack
This PR (3970) (1.829M) : 0, 1829071
master (1.770M) : 0, 1769819
benchmarks/2.27.0 (1.873M) : 0, 1873295
benchmarks/2.9.0 (2.567M) : 0, 2566679
section Blocking
This PR (3970) (3.713M) : 0, 3712918
master (3.710M) : 0, 3709607
benchmarks/2.27.0 (3.750M) : 0, 3750368
|
Code Coverage Report 📊✔️ Merging #3970 into master will not change line coverage
View the full report for further details: Datadog.Trace Breakdown ✔️
The following classes have significant coverage changes.
View the full reports for further details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
3.9instead of3.9.xReason for change
CI complains
Implementation details
2 presses of delete
Test coverage
:stare: