-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use string create if net6.0 or greater #4183
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
90841ee
Use string create if net6.0 or greater
tonyredondo e326991
run benchmarks on net6.0
tonyredondo 5237deb
Merge branch 'master' into tony/use-string-create
tonyredondo 2081f2a
Revert some changes
tonyredondo 7608a8a
revert
tonyredondo 4af57a2
Merge branch 'master' into tony/use-string-create
tonyredondo 7d5e025
Fix BenchmarkComparer
tonyredondo 08a8382
Merge remote-tracking branch 'origin/tony/use-string-create' into ton…
tonyredondo b90638f
Merge branch 'master' into tony/use-string-create
tonyredondo 4ad2dcb
Ensure both data set exists for comparison.
tonyredondo c268b0c
Merge branch 'master' into tony/use-string-create
tonyredondo bd7a80a
Merge branch 'master' into tony/use-string-create
tonyredondo 648e659
Merge branch 'master' into tony/use-string-create
tonyredondo 4d15911
Merge branch 'master' into tony/use-string-create
tonyredondo 40422d4
Merge branch 'master' into tony/use-string-create
tonyredondo d391d08
Merge branch 'master' into tony/use-string-create
tonyredondo 66f17ab
Merge branch 'master' into tony/use-string-create
tonyredondo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically there's a potential issue here if
spanKind.Length > 128 - SpanNamePrefix.Length
. It's very unlikely, and this isinternal
and we control thespanKind
types in this callpath. But it still gives me slight eye twitch! 😄