Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiler] Remove unneeded debug logs (to be replaced by frames related metrics) #4493

Merged
merged 2 commits into from
Sep 4, 2023
Merged

[Profiler] Remove unneeded debug logs (to be replaced by frames related metrics) #4493

merged 2 commits into from
Sep 4, 2023

Conversation

chrisnas
Copy link
Contributor

@chrisnas chrisnas commented Aug 4, 2023

Summary of changes

Remove unneeded debug trace

Reason for change

These frames-related debug logs are not usable as is: they will be replaced by metrics

Implementation details

Remove the code

Test coverage

Other details

@chrisnas chrisnas requested a review from a team as a code owner August 4, 2023 13:55
@andrewlock
Copy link
Member

andrewlock commented Aug 4, 2023 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4493) - mean (74ms)  : 57, 90
     .   : milestone, 74,
    master - mean (70ms)  : 60, 80
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (4493) - mean (1,032ms)  : 1001, 1063
     .   : milestone, 1032,
    master - mean (1,027ms)  : 995, 1058
     .   : milestone, 1027,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4493) - mean (105ms)  : 101, 109
     .   : milestone, 105,
    master - mean (105ms)  : 98, 112
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (4493) - mean (730ms)  : 700, 760
     .   : milestone, 730,
    master - mean (728ms)  : 698, 758
     .   : milestone, 728,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4493) - mean (89ms)  : 86, 92
     .   : milestone, 89,
    master - mean (89ms)  : 85, 93
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (4493) - mean (689ms)  : 660, 717
     .   : milestone, 689,
    master - mean (693ms)  : 656, 730
     .   : milestone, 693,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4493) - mean (188ms)  : 181, 195
     .   : milestone, 188,
    master - mean (188ms)  : 181, 195
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4493) - mean (1,112ms)  : 1070, 1154
     .   : milestone, 1112,
    master - mean (1,120ms)  : 1089, 1152
     .   : milestone, 1120,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4493) - mean (270ms)  : 262, 278
     .   : milestone, 270,
    master - mean (269ms)  : 262, 277
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (4493) - mean (1,091ms)  : 1064, 1119
     .   : milestone, 1091,
    master - mean (1,085ms)  : 1042, 1129
     .   : milestone, 1085,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4493) - mean (261ms)  : 252, 271
     .   : milestone, 261,
    master - mean (259ms)  : 250, 268
     .   : milestone, 259,

    section CallTarget+Inlining+NGEN
    This PR (4493) - mean (1,039ms)  : 994, 1085
     .   : milestone, 1039,
    master - mean (1,028ms)  : 998, 1059
     .   : milestone, 1028,
Loading

@andrewlock
Copy link
Member

andrewlock commented Aug 4, 2023 •
edited
Loading

Benchmarks Report 🐌

Benchmarks for #4493 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.169
  • 4 benchmarks are slower, with geometric mean 1.203
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.97μs 37ns 139ns 0.0199 0.00798 0 7.29 KB
master StartStopWithChild netcoreapp3.1 10.1μs 54ns 301ns 0.0245 0.0122 0 7.4 KB
master StartStopWithChild net472 15.8μs 49.8ns 193ns 1.27 0.307 0.0844 7.66 KB
#4493 StartStopWithChild net6.0 8.29μs 46.6ns 302ns 0.0254 0.0127 0 7.3 KB
#4493 StartStopWithChild netcoreapp3.1 10.2μs 41.7ns 156ns 0.0297 0.0149 0 7.39 KB
#4493 StartStopWithChild net472 15.7μs 56.3ns 218ns 1.28 0.332 0.1 7.67 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 468μs 200ns 721ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 325ns 1.26μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 797μs 361ns 1.4μs 0.396 0 0 3.3 KB
#4493 WriteAndFlushEnrichedTraces net6.0 481μs 358ns 1.29μs 0 0 0 2.7 KB
#4493 WriteAndFlushEnrichedTraces netcoreapp3.1 629μs 348ns 1.21μs 0 0 0 2.7 KB
#4493 WriteAndFlushEnrichedTraces net472 798μs 354ns 1.37μs 0.398 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 39.2μs 24.4ns 94.5ns 0.0201 0 0 1.69 KB
master AllCycleSimpleBody netcoreapp3.1 41.3μs 77.4ns 300ns 0.0205 0 0 1.67 KB
master AllCycleSimpleBody net472 42.8μs 19.7ns 73.9ns 0.257 0 0 1.73 KB
master AllCycleMoreComplexBody net6.0 231μs 76.8ns 266ns 0.115 0 0 9.26 KB
master AllCycleMoreComplexBody netcoreapp3.1 240μs 78ns 292ns 0.12 0 0 9.16 KB
master AllCycleMoreComplexBody net472 250μs 130ns 505ns 1.37 0 0 9.33 KB
master ObjectExtractorSimpleBody net6.0 120ns 0.0372ns 0.139ns 0.00394 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 168ns 0.0553ns 0.207ns 0.00373 0 0 272 B
master ObjectExtractorSimpleBody net472 148ns 0.105ns 0.405ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3μs 0.755ns 2.82ns 0.0541 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.07μs 1.51ns 5.63ns 0.0509 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.06μs 2.62ns 10.1ns 0.618 0.00608 0 3.89 KB
#4493 AllCycleSimpleBody net6.0 39.1μs 25.5ns 92.1ns 0.0195 0 0 1.69 KB
#4493 AllCycleSimpleBody netcoreapp3.1 40.9μs 32.5ns 112ns 0.0206 0 0 1.67 KB
#4493 AllCycleSimpleBody net472 43.4μs 7.92ns 28.5ns 0.259 0 0 1.73 KB
#4493 AllCycleMoreComplexBody net6.0 230μs 142ns 550ns 0.116 0 0 9.26 KB
#4493 AllCycleMoreComplexBody netcoreapp3.1 240μs 270ns 1.01μs 0 0 0 9.16 KB
#4493 AllCycleMoreComplexBody net472 249μs 65.8ns 255ns 1.37 0 0 9.33 KB
#4493 ObjectExtractorSimpleBody net6.0 124ns 0.0194ns 0.0727ns 0.00396 0 0 280 B
#4493 ObjectExtractorSimpleBody netcoreapp3.1 175ns 0.142ns 0.53ns 0.00369 0 0 272 B
#4493 ObjectExtractorSimpleBody net472 147ns 0.135ns 0.524ns 0.0446 0 0 281 B
#4493 ObjectExtractorMoreComplexBody net6.0 2.98μs 0.862ns 3.11ns 0.0543 0 0 3.88 KB
#4493 ObjectExtractorMoreComplexBody netcoreapp3.1 4.27μs 1.85ns 6.93ns 0.0512 0 0 3.78 KB
#4493 ObjectExtractorMoreComplexBody net472 4.14μs 5.66ns 21.2ns 0.617 0.00617 0 3.89 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 118μs 748ns 7.06μs 0 0 0 17.62 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 129μs 652ns 4.07μs 0 0 0 16.79 KB
master RunWaf(args=NestedMap (10)) net472 127μs 580ns 2.32μs 0 0 0 24.58 KB
master RunWaf(args=NestedMap (100)) net6.0 228μs 1.14μs 4.96μs 0 0 0 37.95 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 262μs 1.39μs 10.7μs 0 0 0 37.78 KB
master RunWaf(args=NestedMap (100)) net472 256μs 1.28μs 5.56μs 0 0 0 40.96 KB
master RunWaf(args=NestedMap (1000)) net6.0 224μs 624ns 2.42μs 0 0 0 37.95 KB
master RunWaf(args=NestedMap (1000)) netcoreapp3.1 257μs 826ns 2.86μs 0 0 0 37.78 KB
master RunWaf(args=NestedMap (1000)) net472 259μs 1.14μs 4.12μs 0 0 0 40.96 KB
#4493 RunWaf(args=NestedMap (10)) net6.0 120μs 697ns 6.04μs 0 0 0 17.62 KB
#4493 RunWaf(args=NestedMap (10)) netcoreapp3.1 130μs 675ns 3.37μs 0 0 0 16.79 KB
#4493 RunWaf(args=NestedMap (10)) net472 128μs 605ns 2.42μs 0 0 0 24.58 KB
#4493 RunWaf(args=NestedMap (100)) net6.0 228μs 995ns 4.67μs 0 0 0 37.95 KB
#4493 RunWaf(args=NestedMap (100)) netcoreapp3.1 262μs 1.48μs 9.96μs 0 0 0 37.78 KB
#4493 RunWaf(args=NestedMap (100)) net472 259μs 1.25μs 5.01μs 0 0 0 40.96 KB
#4493 RunWaf(args=NestedMap (1000)) net6.0 224μs 940ns 3.26μs 0 0 0 37.95 KB
#4493 RunWaf(args=NestedMap (1000)) netcoreapp3.1 253μs 1.33μs 6.5μs 0 0 0 37.78 KB
#4493 RunWaf(args=NestedMap (1000)) net472 255μs 839ns 3.02μs 0 0 0 40.96 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 169μs 83.8ns 302ns 0.254 0 0 18.09 KB
master SendRequest netcoreapp3.1 191μs 281ns 1.09μs 0.19 0 0 20.25 KB
master SendRequest net472 0.000995ns 0.000319ns 0.00119ns 0 0 0 0 b
#4493 SendRequest net6.0 170μs 60ns 208ns 0.253 0 0 18.09 KB
#4493 SendRequest netcoreapp3.1 193μs 343ns 1.33μs 0.194 0 0 20.25 KB
#4493 SendRequest net472 0.000697ns 0.000301ns 0.00117ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #4493

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.46 KB 41.69 KB 230 B 0.55%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 517μs 849ns 2.94μs 0.534 0 0 41.46 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 1.53μs 5.92μs 0.314 0 0 41.75 KB
master WriteAndFlushEnrichedTraces net472 788μs 2.95μs 11.4μs 8.2 2.34 0.391 53.24 KB
#4493 WriteAndFlushEnrichedTraces net6.0 514μs 372ns 1.44μs 0.512 0 0 41.69 KB
#4493 WriteAndFlushEnrichedTraces netcoreapp3.1 620μs 1.58μs 6.12μs 0.305 0 0 41.6 KB
#4493 WriteAndFlushEnrichedTraces net472 804μs 3.14μs 12.2μs 8.36 2.39 0.398 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.04μs 0.277ns 1.07ns 0.0105 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.38μs 0.67ns 2.6ns 0.0102 0 0 768 B
master ExecuteNonQuery net472 1.66μs 0.877ns 3.4ns 0.116 0 0 730 B
#4493 ExecuteNonQuery net6.0 1.07μs 0.763ns 2.95ns 0.0107 0 0 768 B
#4493 ExecuteNonQuery netcoreapp3.1 1.39μs 0.677ns 2.62ns 0.0105 0 0 768 B
#4493 ExecuteNonQuery net472 1.67μs 0.494ns 1.85ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 1.07ns 4.13ns 0.014 0 0 992 B
master CallElasticsearch netcoreapp3.1 1.5μs 1.15ns 4.3ns 0.0134 0 0 992 B
master CallElasticsearch net472 2.29μs 0.583ns 2.26ns 0.159 0.00114 0 1 KB
master CallElasticsearchAsync net6.0 1.3μs 0.972ns 3.76ns 0.0137 0 0 968 B
master CallElasticsearchAsync netcoreapp3.1 1.58μs 0.55ns 2.13ns 0.0133 0 0 1.04 KB
master CallElasticsearchAsync net472 2.47μs 1.09ns 4.07ns 0.168 0.00123 0 1.06 KB
#4493 CallElasticsearch net6.0 1.18μs 0.544ns 2.04ns 0.0141 0 0 992 B
#4493 CallElasticsearch netcoreapp3.1 1.59μs 0.915ns 3.42ns 0.0135 0 0 992 B
#4493 CallElasticsearch net472 2.21μs 0.825ns 3.19ns 0.159 0 0 1 KB
#4493 CallElasticsearchAsync net6.0 1.27μs 0.66ns 2.47ns 0.0133 0 0 968 B
#4493 CallElasticsearchAsync netcoreapp3.1 1.6μs 0.5ns 1.94ns 0.0145 0 0 1.04 KB
#4493 CallElasticsearchAsync net472 2.58μs 1.2ns 4.65ns 0.168 0.00144 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4493

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.130 1,185.68 1,340.41

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.18μs 1.38ns 5.33ns 0.0125 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.54μs 0.562ns 2.1ns 0.0123 0 0 912 B
master ExecuteAsync net472 1.65μs 0.633ns 2.45ns 0.139 0 0 875 B
#4493 ExecuteAsync net6.0 1.34μs 2.13ns 8.26ns 0.0128 0 0 912 B
#4493 ExecuteAsync netcoreapp3.1 1.47μs 0.652ns 2.35ns 0.0118 0 0 912 B
#4493 ExecuteAsync net472 1.69μs 1.12ns 4.19ns 0.138 0.000843 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.8μs 1.13ns 4.09ns 0.0272 0 0 1.94 KB
master SendAsync netcoreapp3.1 4.44μs 14.6ns 54.4ns 0.0328 0 0 2.48 KB
master SendAsync net472 7.15μs 6.52ns 25.2ns 0.484 0 0 3.05 KB
#4493 SendAsync net6.0 3.71μs 1.04ns 4.04ns 0.0261 0 0 1.94 KB
#4493 SendAsync netcoreapp3.1 4.59μs 1.55ns 5.6ns 0.0323 0 0 2.48 KB
#4493 SendAsync net472 7.16μs 3.32ns 12.9ns 0.481 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4493

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.169 1,542.75 1,319.48

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 0.814ns 3.04ns 0.0223 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.87μs 0.693ns 2.59ns 0.0222 0 0 1.62 KB
master EnrichedLog net472 2.35μs 2.28ns 8.83ns 0.244 0 0 1.54 KB
#4493 EnrichedLog net6.0 1.32μs 0.569ns 2.13ns 0.023 0 0 1.62 KB
#4493 EnrichedLog netcoreapp3.1 1.85μs 0.682ns 2.55ns 0.0223 0 0 1.62 KB
#4493 EnrichedLog net472 2.3μs 1.88ns 7.03ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 79.1ns 306ns 0.0562 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 118μs 127ns 491ns 0.059 0 0 4.21 KB
master EnrichedLog net472 148μs 236ns 912ns 0.663 0.221 0 4.38 KB
#4493 EnrichedLog net6.0 113μs 74.5ns 289ns 0.0568 0 0 4.21 KB
#4493 EnrichedLog netcoreapp3.1 118μs 274ns 1.06μs 0.0598 0 0 4.21 KB
#4493 EnrichedLog net472 147μs 144ns 556ns 0.66 0.22 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.97μs 1.03ns 3.7ns 0.0307 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.86μs 4.83ns 18.7ns 0.0286 0 0 2.18 KB
master EnrichedLog net472 4.61μs 2.93ns 10.6ns 0.315 0 0 1.99 KB
#4493 EnrichedLog net6.0 2.82μs 0.984ns 3.55ns 0.0306 0 0 2.18 KB
#4493 EnrichedLog netcoreapp3.1 3.77μs 1.33ns 4.79ns 0.0281 0 0 2.18 KB
#4493 EnrichedLog net472 4.51μs 1.99ns 7.69ns 0.315 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.34μs 0.811ns 3.04ns 0.0166 0 0 1.16 KB
master SendReceive netcoreapp3.1 1.65μs 1.99ns 7.71ns 0.0156 0 0 1.16 KB
master SendReceive net472 2.02μs 1.31ns 5.07ns 0.184 0 0 1.16 KB
#4493 SendReceive net6.0 1.35μs 0.888ns 3.32ns 0.0162 0 0 1.16 KB
#4493 SendReceive netcoreapp3.1 1.65μs 0.733ns 2.84ns 0.0157 0 0 1.16 KB
#4493 SendReceive net472 1.96μs 9.53ns 42.6ns 0.184 0.000965 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.5μs 0.952ns 3.69ns 0.0213 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.64μs 1.71ns 6.4ns 0.0198 0 0 1.58 KB
master EnrichedLog net472 4.04μs 0.843ns 3.16ns 0.311 0 0 1.96 KB
#4493 EnrichedLog net6.0 2.75μs 1.11ns 4.15ns 0.022 0 0 1.53 KB
#4493 EnrichedLog netcoreapp3.1 3.57μs 11.7ns 45.3ns 0.0212 0 0 1.58 KB
#4493 EnrichedLog net472 3.99μs 2.11ns 8.17ns 0.311 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4493

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.189 470.55 559.42
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.118 402.34 449.86

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 403ns 0.168ns 0.629ns 0.00753 0 0 536 B
master StartFinishSpan netcoreapp3.1 564ns 0.206ns 0.771ns 0.00738 0 0 536 B
master StartFinishSpan net472 630ns 0.105ns 0.38ns 0.0853 0 0 538 B
master StartFinishScope net6.0 471ns 0.148ns 0.555ns 0.00922 0 0 656 B
master StartFinishScope netcoreapp3.1 682ns 0.229ns 0.858ns 0.00892 0 0 656 B
master StartFinishScope net472 828ns 0.288ns 1.11ns 0.098 0 0 618 B
#4493 StartFinishSpan net6.0 450ns 0.123ns 0.476ns 0.00745 0 0 536 B
#4493 StartFinishSpan netcoreapp3.1 511ns 0.183ns 0.684ns 0.00723 0 0 536 B
#4493 StartFinishSpan net472 651ns 0.0977ns 0.366ns 0.0851 0 0 538 B
#4493 StartFinishScope net6.0 559ns 0.143ns 0.534ns 0.00924 0 0 656 B
#4493 StartFinishScope netcoreapp3.1 715ns 0.235ns 0.815ns 0.00897 0 0 656 B
#4493 StartFinishScope net472 858ns 0.525ns 2.03ns 0.0979 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4493

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.394 510.88 712.32

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 511ns 0.224ns 0.837ns 0.00919 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 843ns 0.46ns 1.78ns 0.0088 0 0 656 B
master RunOnMethodBegin net472 1.03μs 0.405ns 1.57ns 0.098 0 0 618 B
#4493 RunOnMethodBegin net6.0 712ns 0.332ns 1.29ns 0.00925 0 0 656 B
#4493 RunOnMethodBegin netcoreapp3.1 903ns 1.84ns 6.87ns 0.00893 0 0 656 B
#4493 RunOnMethodBegin net472 964ns 0.306ns 1.1ns 0.0981 0 0 618 B

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Aug 4, 2023 •
edited
Loading

Datadog Report

Branch report: chrisnas/remove_debug_logs
Commit report: 0071867

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 296069 Passed, 1091 Skipped, 39m 36.45s Wall Time

@andrewlock
Copy link
Member

andrewlock commented Aug 4, 2023 •
edited
Loading

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4493) (10.814M)   : 0, 10813515
    master (11.052M)   : 0, 11052280
    benchmarks/2.37.0 (11.079M)   : 0, 11079403
    benchmarks/2.9.0 (10.819M)   : 0, 10818572

    section Automatic
    This PR (4493) (7.487M)   : 0, 7486629
    master (7.759M)   : 0, 7759092
    benchmarks/2.37.0 (7.794M)   : 0, 7793640
    benchmarks/2.9.0 (7.798M)   : 0, 7797649

    section Trace stats
    master (7.741M)   : 0, 7740593
    benchmarks/2.37.0 (7.751M)   : 0, 7750680

    section Manual
    This PR (4493) (9.707M)   : 0, 9706777
    master (9.823M)   : 0, 9822986
    benchmarks/2.37.0 (10.029M)   : 0, 10029063

    section Manual + Automatic
    This PR (4493) (7.194M)   : 0, 7193635
    master (7.495M)   : 0, 7494786
    benchmarks/2.37.0 (7.498M)   : 0, 7498234

    section Version Conflict
    master (6.659M)   : 0, 6659164
    benchmarks/2.37.0 (6.664M)   : 0, 6664415
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4493) (9.644M)   : 0, 9643906
    master (9.640M)   : 0, 9640273
    benchmarks/2.37.0 (9.548M)   : 0, 9548039
    benchmarks/2.9.0 (9.745M)   : 0, 9745254

    section Automatic
    This PR (4493) (6.826M)   : 0, 6825571
    master (6.802M)   : 0, 6801747
    benchmarks/2.37.0 (6.800M)   : 0, 6799760

    section Trace stats
    master (6.784M)   : 0, 6783718
    benchmarks/2.37.0 (6.742M)   : 0, 6742080

    section Manual
    This PR (4493) (8.645M)   : 0, 8644979
    master (8.521M)   : 0, 8520638
    benchmarks/2.37.0 (8.470M)   : 0, 8470308

    section Manual + Automatic
    This PR (4493) (6.503M)   : 0, 6503472
    master (6.414M)   : 0, 6414242
    benchmarks/2.37.0 (6.541M)   : 0, 6540947

    section Version Conflict
    master (5.977M)   : 0, 5976573
    benchmarks/2.37.0 (5.863M)   : 0, 5863075
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4493) (10.117M)   : 0, 10117446
    master (10.583M)   : 0, 10583298
    benchmarks/2.37.0 (10.314M)   : 0, 10313577
    benchmarks/2.9.0 (10.477M)   : 0, 10476815

    section Automatic
    This PR (4493) (7.496M)   : 0, 7495625
    master (7.582M)   : 0, 7582322
    benchmarks/2.37.0 (7.311M)   : 0, 7311023
    benchmarks/2.9.0 (7.349M)   : 0, 7349189

    section Trace stats
    master (7.528M)   : 0, 7527553
    benchmarks/2.37.0 (7.132M)   : 0, 7132134

    section Manual
    This PR (4493) (9.043M)   : 0, 9043111
    master (9.501M)   : 0, 9500922
    benchmarks/2.37.0 (8.871M)   : 0, 8870667

    section Manual + Automatic
    This PR (4493) (7.007M)   : 0, 7006513
    master (7.365M)   : 0, 7364931
    benchmarks/2.37.0 (7.284M)   : 0, 7284329

    section Version Conflict
    master (6.700M)   : 0, 6700301
    benchmarks/2.37.0 (6.765M)   : 0, 6764908
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4493) (7.515M)   : 0, 7514695
    master (7.605M)   : 0, 7604905
    benchmarks/2.37.0 (7.544M)   : 0, 7543600
    benchmarks/2.9.0 (7.825M)   : 0, 7824572

    section No attack
    This PR (4493) (2.162M)   : 0, 2162319
    master (2.153M)   : 0, 2153311
    benchmarks/2.37.0 (2.167M)   : 0, 2166801
    benchmarks/2.9.0 (3.192M)   : 0, 3192372

    section Attack
    This PR (4493) (1.683M)   : 0, 1683368
    master (1.696M)   : 0, 1696274
    benchmarks/2.37.0 (1.676M)   : 0, 1675674
    benchmarks/2.9.0 (2.514M)   : 0, 2513925

    section Blocking
    This PR (4493) (3.059M)   : 0, 3059158
    master (3.121M)   : 0, 3120637
    benchmarks/2.37.0 (3.158M)   : 0, 3157727
Loading

gleocadie
gleocadie approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Sep 4, 2023 •
edited
Loading

Datadog Report

Branch report: chrisnas/remove_debug_logs
Commit report: 9be9027

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 301267 Passed, 1115 Skipped, 21m 31.78s Wall Time

@chrisnas chrisnas merged commit 1b5663c into master Sep 4, 2023
57 checks passed
@chrisnas chrisnas deleted the chrisnas/remove_debug_logs branch September 4, 2023 10:57
@github-actions github-actions bot added this to the vNext milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleocadie gleocadie gleocadie approved these changes

Assignees
No one assigned
Labels
area:profiler
Projects
None yet
Milestone
2.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisnas @andrewlock @gleocadie