Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crank: add logs as artifacts #4607

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Crank: add logs as artifacts #4607

merged 3 commits into from
Sep 11, 2023

Conversation

anna-git
Copy link
Contributor

Summary of changes

Export logs as artifacts in CI. See example here: https://dev.azure.com/datadoghq/dd-trace-dotnet/_build/results?buildId=143966&view=artifacts&pathAsName=false&type=publishedArtifacts
(After many attempts, can't get rid of the logs/logs folder subtree)

Reason for change

It's hard to see logs, you need to connect to the servers and they might have been gone by then

Implementation details

Use the outputfiles property from crank

Test coverage

Other details

@anna-git anna-git added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Sep 11, 2023
@anna-git anna-git requested a review from a team as a code owner September 11, 2023 08:03
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4607) - mean (71ms)  : 60, 81
     .   : milestone, 71,
    master - mean (68ms)  : 64, 73
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (4607) - mean (1,016ms)  : 973, 1059
     .   : milestone, 1016,
    master - mean (1,013ms)  : 985, 1042
     .   : milestone, 1013,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4607) - mean (106ms)  : 96, 115
     .   : milestone, 106,
    master - mean (106ms)  : 99, 112
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4607) - mean (700ms)  : 676, 725
     .   : milestone, 700,
    master - mean (697ms)  : 671, 722
     .   : milestone, 697,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4607) - mean (89ms)  : 85, 93
     .   : milestone, 89,
    master - mean (90ms)  : 80, 99
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (4607) - mean (666ms)  : 633, 700
     .   : milestone, 666,
    master - mean (667ms)  : 638, 697
     .   : milestone, 667,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4607) - mean (189ms)  : 186, 192
     .   : milestone, 189,
    master - mean (191ms)  : 185, 198
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (4607) - mean (1,116ms)  : 1062, 1171
     .   : milestone, 1116,
    master - mean (1,115ms)  : 1078, 1152
     .   : milestone, 1115,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4607) - mean (274ms)  : 267, 281
     .   : milestone, 274,
    master - mean (271ms)  : 263, 279
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (4607) - mean (1,052ms)  : 1001, 1102
     .   : milestone, 1052,
    master - mean (1,062ms)  : 1033, 1090
     .   : milestone, 1062,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4607) - mean (255ms)  : 245, 266
     .   : milestone, 255,
    master - mean (265ms)  : 236, 294
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (4607) - mean (1,015ms)  : 989, 1042
     .   : milestone, 1015,
    master - mean (1,004ms)  : 982, 1026
     .   : milestone, 1004,
Loading

andrewlock
andrewlock approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks! 🎉

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Sep 11, 2023 •
edited
Loading

Datadog Report

Branch report: anna/add-logs-artifacts-throughputs
Commit report: 093f678

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 301644 Passed, 1115 Skipped, 35m 25.86s Wall Time

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4607 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.165
  • 3 benchmarks are slower, with geometric mean 1.149
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.07μs 39.7ns 217ns 0.0199 0.00796 0 7.3 KB
master StartStopWithChild netcoreapp3.1 9.89μs 53.8ns 327ns 0.0283 0.0142 0 7.39 KB
master StartStopWithChild net472 15.6μs 53.1ns 206ns 1.29 0.322 0.102 7.68 KB
#4607 StartStopWithChild net6.0 8.19μs 43.2ns 259ns 0.0213 0.00853 0 7.29 KB
#4607 StartStopWithChild netcoreapp3.1 10.2μs 56ns 312ns 0.0251 0.01 0 7.39 KB
#4607 StartStopWithChild net472 15.7μs 46.9ns 182ns 1.31 0.348 0.1 7.68 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 489μs 427ns 1.65μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 241ns 933ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 805μs 259ns 1μs 0.403 0 0 3.3 KB
#4607 WriteAndFlushEnrichedTraces net6.0 461μs 249ns 963ns 0 0 0 2.7 KB
#4607 WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 233ns 870ns 0 0 0 2.7 KB
#4607 WriteAndFlushEnrichedTraces net472 815μs 322ns 1.21μs 0.406 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.8μs 36.9ns 143ns 0.0194 0 0 1.69 KB
master AllCycleSimpleBody netcoreapp3.1 43μs 58.2ns 218ns 0.0208 0 0 1.67 KB
master AllCycleSimpleBody net472 42.3μs 14.3ns 53.5ns 0.274 0 0 1.73 KB
master AllCycleMoreComplexBody net6.0 229μs 35.1ns 127ns 0.115 0 0 9.26 KB
master AllCycleMoreComplexBody netcoreapp3.1 239μs 139ns 538ns 0 0 0 9.16 KB
master AllCycleMoreComplexBody net472 246μs 65.9ns 255ns 1.36 0 0 9.33 KB
master ObjectExtractorSimpleBody net6.0 126ns 0.0534ns 0.2ns 0.00396 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 173ns 0.115ns 0.43ns 0.00374 0 0 272 B
master ObjectExtractorSimpleBody net472 145ns 0.141ns 0.545ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.05μs 0.984ns 3.68ns 0.0537 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.08μs 1.29ns 5.01ns 0.0512 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.12μs 3.63ns 14.1ns 0.617 0.00613 0 3.89 KB
#4607 AllCycleSimpleBody net6.0 39μs 17.5ns 65.6ns 0.0196 0 0 1.69 KB
#4607 AllCycleSimpleBody netcoreapp3.1 41.3μs 55.9ns 209ns 0.0205 0 0 1.67 KB
#4607 AllCycleSimpleBody net472 43μs 11.5ns 44.5ns 0.258 0 0 1.73 KB
#4607 AllCycleMoreComplexBody net6.0 232μs 81.7ns 316ns 0.114 0 0 9.26 KB
#4607 AllCycleMoreComplexBody netcoreapp3.1 238μs 250ns 1μs 0.118 0 0 9.16 KB
#4607 AllCycleMoreComplexBody net472 248μs 55.7ns 208ns 1.48 0 0 9.33 KB
#4607 ObjectExtractorSimpleBody net6.0 120ns 0.0482ns 0.187ns 0.00396 0 0 280 B
#4607 ObjectExtractorSimpleBody netcoreapp3.1 169ns 0.0546ns 0.211ns 0.00373 0 0 272 B
#4607 ObjectExtractorSimpleBody net472 145ns 0.14ns 0.543ns 0.0446 0 0 281 B
#4607 ObjectExtractorMoreComplexBody net6.0 3μs 0.867ns 3.36ns 0.0536 0 0 3.88 KB
#4607 ObjectExtractorMoreComplexBody netcoreapp3.1 3.94μs 1.81ns 6.77ns 0.0511 0 0 3.78 KB
#4607 ObjectExtractorMoreComplexBody net472 4.09μs 2.06ns 7.97ns 0.617 0.00613 0 3.89 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 150ms 332μs 1.29ms 0 0 0 33.94 MB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 168ms 203μs 733μs 0 0 0 33.94 MB
master RunWaf(args=NestedMap (10)) net472 248ms 973μs 3.77ms 6E+03 3E+03 2E+03 35.2 MB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 167ms 238μs 889μs 0 0 0 33.95 MB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 184ms 356μs 1.38ms 0 0 0 33.95 MB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 250ms 193μs 696μs 5E+03 2E+03 1E+03 35.19 MB
master RunWaf(args=NestedMap (100)) net6.0 301ms 853μs 3.31ms 0 0 0 73.6 MB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 342ms 761μs 2.95ms 0 0 0 74.99 MB
master RunWaf(args=NestedMap (100)) net472 506ms 556μs 2.15ms 1.1E+04 5E+03 2E+03 78.67 MB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 330ms 689μs 2.58ms 0 0 0 73.69 MB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 363ms 799μs 2.99ms 0 0 0 75 MB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 537ms 1.06ms 4.09ms 1.1E+04 5E+03 2E+03 78.67 MB
master RunWaf(args=NestedMap (1000)) net6.0 298ms 801μs 2.89ms 0 0 0 73.6 MB
master RunWaf(args=NestedMap (1000)) netcoreapp3.1 344ms 915μs 3.3ms 0 0 0 74.91 MB
master RunWaf(args=NestedMap (1000)) net472 518ms 2.48ms 10.5ms 1.1E+04 5E+03 2E+03 78.67 MB
master RunWafWithAttack(args=Neste(...)tack) [24]) net6.0 322ms 1.36ms 5.09ms 0 0 0 73.6 MB
master RunWafWithAttack(args=Neste(...)tack) [24]) netcoreapp3.1 370ms 1.04ms 4.05ms 0 0 0 74.91 MB
master RunWafWithAttack(args=Neste(...)tack) [24]) net472 538ms 601μs 2.33ms 1.1E+04 5E+03 2E+03 78.67 MB
#4607 RunWaf(args=NestedMap (10)) net6.0 150ms 165μs 595μs 0 0 0 33.94 MB
#4607 RunWaf(args=NestedMap (10)) netcoreapp3.1 161ms 272μs 979μs 0 0 0 33.94 MB
#4607 RunWaf(args=NestedMap (10)) net472 242ms 1.3ms 7.27ms 6E+03 3E+03 2E+03 35.19 MB
#4607 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 171ms 159μs 573μs 0 0 0 33.95 MB
#4607 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 182ms 255μs 986μs 0 0 0 33.95 MB
#4607 RunWafWithAttack(args=Neste(...)tack) [22]) net472 246ms 286μs 1.11ms 5E+03 2E+03 1E+03 35.21 MB
#4607 RunWaf(args=NestedMap (100)) net6.0 303ms 1.19ms 4.62ms 0 0 0 73.6 MB
#4607 RunWaf(args=NestedMap (100)) netcoreapp3.1 334ms 696μs 2.6ms 0 0 0 74.91 MB
#4607 RunWaf(args=NestedMap (100)) net472 509ms 495μs 1.85ms 1.1E+04 5E+03 2E+03 78.68 MB
#4607 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 329ms 885μs 3.43ms 0 0 0 73.6 MB
#4607 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 360ms 845μs 3.05ms 0 0 0 75 MB
#4607 RunWafWithAttack(args=Neste(...)tack) [23]) net472 532ms 1.93ms 7.46ms 1.1E+04 5E+03 2E+03 78.71 MB
#4607 RunWaf(args=NestedMap (1000)) net6.0 308ms 987μs 3.69ms 0 0 0 73.6 MB
#4607 RunWaf(args=NestedMap (1000)) netcoreapp3.1 338ms 826μs 3.2ms 0 0 0 74.91 MB
#4607 RunWaf(args=NestedMap (1000)) net472 524ms 2.39ms 9.25ms 1.1E+04 5E+03 2E+03 78.67 MB
#4607 RunWafWithAttack(args=Neste(...)tack) [24]) net6.0 332ms 522μs 1.88ms 0 0 0 73.6 MB
#4607 RunWafWithAttack(args=Neste(...)tack) [24]) netcoreapp3.1 367ms 963μs 3.73ms 0 0 0 74.91 MB
#4607 RunWafWithAttack(args=Neste(...)tack) [24]) net472 539ms 341μs 1.23ms 1.1E+04 5E+03 2E+03 78.73 MB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 68.1ns 255ns 0.171 0 0 18.09 KB
master SendRequest netcoreapp3.1 190μs 288ns 1.08μs 0.19 0 0 20.25 KB
master SendRequest net472 0.000777ns 0.000282ns 0.00109ns 0 0 0 0 b
#4607 SendRequest net6.0 169μs 172ns 667ns 0.169 0 0 18.09 KB
#4607 SendRequest netcoreapp3.1 190μs 184ns 687ns 0.191 0 0 20.25 KB
#4607 SendRequest net472 0.00104ns 0.000363ns 0.00141ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #4607

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.61 KB 41.95 KB 339 B 0.81%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 542μs 348ns 1.35μs 0.532 0 0 41.76 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 1.87μs 7.25μs 0.319 0 0 41.61 KB
master WriteAndFlushEnrichedTraces net472 774μs 2.1μs 7.84μs 8.31 2.37 0.396 53.22 KB
#4607 WriteAndFlushEnrichedTraces net6.0 527μs 160ns 599ns 0.506 0 0 41.84 KB
#4607 WriteAndFlushEnrichedTraces netcoreapp3.1 621μs 921ns 3.57μs 0.302 0 0 41.95 KB
#4607 WriteAndFlushEnrichedTraces net472 773μs 3.68μs 14.2μs 8.38 2.67 0.381 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.04μs 0.596ns 2.15ns 0.0108 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.31μs 0.887ns 3.44ns 0.0104 0 0 768 B
master ExecuteNonQuery net472 1.67μs 0.373ns 1.4ns 0.115 0.000836 0 730 B
#4607 ExecuteNonQuery net6.0 976ns 0.33ns 1.28ns 0.0107 0 0 768 B
#4607 ExecuteNonQuery netcoreapp3.1 1.41μs 0.587ns 2.2ns 0.0104 0 0 768 B
#4607 ExecuteNonQuery net472 1.63μs 4.13ns 16ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4607

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.135 1,185.13 1,345.70

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.26μs 0.596ns 2.31ns 0.0135 0 0 992 B
master CallElasticsearch netcoreapp3.1 1.5μs 2.52ns 9.76ns 0.0136 0 0 992 B
master CallElasticsearch net472 2.38μs 0.819ns 3.06ns 0.158 0.00119 0 1 KB
master CallElasticsearchAsync net6.0 1.19μs 0.707ns 2.55ns 0.0137 0 0 968 B
master CallElasticsearchAsync netcoreapp3.1 1.49μs 1.02ns 3.82ns 0.0135 0 0 1.04 KB
master CallElasticsearchAsync net472 2.44μs 0.595ns 2.31ns 0.168 0.00122 0 1.06 KB
#4607 CallElasticsearch net6.0 1.18μs 0.466ns 1.75ns 0.0142 0 0 992 B
#4607 CallElasticsearch netcoreapp3.1 1.49μs 0.539ns 2.09ns 0.0133 0 0 992 B
#4607 CallElasticsearch net472 2.43μs 0.543ns 2.03ns 0.159 0 0 1 KB
#4607 CallElasticsearchAsync net6.0 1.35μs 0.453ns 1.69ns 0.0135 0 0 968 B
#4607 CallElasticsearchAsync netcoreapp3.1 1.51μs 0.499ns 1.87ns 0.0136 0 0 1.04 KB
#4607 CallElasticsearchAsync net472 2.53μs 0.793ns 3.07ns 0.168 0.00126 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.17μs 0.649ns 2.43ns 0.0124 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.44μs 0.565ns 2.12ns 0.0123 0 0 912 B
master ExecuteAsync net472 1.66μs 1.15ns 4.44ns 0.138 0.000834 0 875 B
#4607 ExecuteAsync net6.0 1.25μs 0.435ns 1.63ns 0.0126 0 0 912 B
#4607 ExecuteAsync netcoreapp3.1 1.53μs 0.994ns 3.85ns 0.0123 0 0 912 B
#4607 ExecuteAsync net472 1.76μs 0.749ns 2.9ns 0.138 0.000876 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.87μs 1.45ns 5.44ns 0.0271 0 0 1.94 KB
master SendAsync netcoreapp3.1 4.41μs 2.39ns 8.61ns 0.0332 0 0 2.48 KB
master SendAsync net472 7.22μs 2.81ns 10.9ns 0.483 0 0 3.05 KB
#4607 SendAsync net6.0 3.71μs 1.56ns 6.06ns 0.0258 0 0 1.94 KB
#4607 SendAsync netcoreapp3.1 4.45μs 1.33ns 4.98ns 0.0334 0 0 2.48 KB
#4607 SendAsync net472 7.25μs 2.61ns 10.1ns 0.482 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4607

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.193 1,537.89 1,289.33

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 0.558ns 2.09ns 0.0231 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 2μs 0.922ns 3.57ns 0.022 0 0 1.62 KB
master EnrichedLog net472 2.43μs 1.19ns 4.63ns 0.244 0 0 1.54 KB
#4607 EnrichedLog net6.0 1.29μs 0.456ns 1.64ns 0.0225 0 0 1.62 KB
#4607 EnrichedLog netcoreapp3.1 1.96μs 1.28ns 4.79ns 0.0216 0 0 1.62 KB
#4607 EnrichedLog net472 2.39μs 3.29ns 12.7ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 162ns 629ns 0.0562 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 119μs 308ns 1.15μs 0.0582 0 0 4.21 KB
master EnrichedLog net472 147μs 119ns 460ns 0.657 0.219 0 4.38 KB
#4607 EnrichedLog net6.0 113μs 113ns 408ns 0.0567 0 0 4.21 KB
#4607 EnrichedLog netcoreapp3.1 118μs 94ns 352ns 0 0 0 4.21 KB
#4607 EnrichedLog net472 147μs 120ns 465ns 0.656 0.219 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.91μs 1.18ns 4.42ns 0.0304 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 4μs 1.51ns 5.64ns 0.03 0 0 2.18 KB
master EnrichedLog net472 4.61μs 1.09ns 4.06ns 0.315 0 0 1.99 KB
#4607 EnrichedLog net6.0 2.88μs 0.65ns 2.43ns 0.0302 0 0 2.18 KB
#4607 EnrichedLog netcoreapp3.1 3.9μs 1.56ns 5.83ns 0.0291 0 0 2.18 KB
#4607 EnrichedLog net472 4.59μs 1.51ns 5.66ns 0.314 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.3μs 0.564ns 2.11ns 0.0163 0 0 1.16 KB
master SendReceive netcoreapp3.1 1.59μs 1.24ns 4.81ns 0.0158 0 0 1.16 KB
master SendReceive net472 2μs 2.26ns 8.76ns 0.184 0 0 1.16 KB
#4607 SendReceive net6.0 1.29μs 0.609ns 2.36ns 0.0161 0 0 1.16 KB
#4607 SendReceive netcoreapp3.1 1.61μs 1.7ns 6.57ns 0.0152 0 0 1.16 KB
#4607 SendReceive net472 2.01μs 0.905ns 3.51ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.62μs 0.85ns 3.29ns 0.021 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.51μs 1.27ns 4.77ns 0.021 0 0 1.58 KB
master EnrichedLog net472 4.16μs 1.58ns 6.13ns 0.309 0 0 1.96 KB
#4607 EnrichedLog net6.0 2.52μs 0.638ns 2.39ns 0.0214 0 0 1.53 KB
#4607 EnrichedLog netcoreapp3.1 3.68μs 0.848ns 3.06ns 0.0202 0 0 1.58 KB
#4607 EnrichedLog net472 4.05μs 1.96ns 7.35ns 0.311 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4607

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.165 614.35 715.65
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.146 397.66 455.81

Faster 🎉 in #4607

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.139 538.97 473.30

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 398ns 0.14ns 0.523ns 0.0075 0 0 536 B
master StartFinishSpan netcoreapp3.1 570ns 0.998ns 3.87ns 0.00734 0 0 536 B
master StartFinishSpan net472 614ns 0.149ns 0.516ns 0.0854 0 0 538 B
master StartFinishScope net6.0 540ns 1.04ns 3.76ns 0.00916 0 0 656 B
master StartFinishScope netcoreapp3.1 694ns 0.355ns 1.28ns 0.0087 0 0 656 B
master StartFinishScope net472 813ns 0.417ns 1.62ns 0.0981 0 0 618 B
#4607 StartFinishSpan net6.0 456ns 0.114ns 0.428ns 0.00756 0 0 536 B
#4607 StartFinishSpan netcoreapp3.1 516ns 0.174ns 0.672ns 0.00743 0 0 536 B
#4607 StartFinishSpan net472 716ns 0.158ns 0.589ns 0.0852 0 0 538 B
#4607 StartFinishScope net6.0 474ns 0.159ns 0.616ns 0.00916 0 0 656 B
#4607 StartFinishScope netcoreapp3.1 741ns 0.348ns 1.35ns 0.00884 0 0 656 B
#4607 StartFinishScope net472 852ns 0.556ns 2.15ns 0.098 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 615ns 0.263ns 1.02ns 0.00915 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 820ns 0.259ns 0.968ns 0.00866 0 0 656 B
master RunOnMethodBegin net472 1.03μs 0.238ns 0.922ns 0.0979 0 0 618 B
#4607 RunOnMethodBegin net6.0 600ns 0.192ns 0.745ns 0.00924 0 0 656 B
#4607 RunOnMethodBegin netcoreapp3.1 803ns 0.439ns 1.7ns 0.00869 0 0 656 B
#4607 RunOnMethodBegin net472 931ns 0.213ns 0.77ns 0.098 0 0 618 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4607) (11.563M)   : 0, 11563030
    master (11.025M)   : 0, 11024671
    benchmarks/2.37.0 (10.984M)   : 0, 10983597
    benchmarks/2.9.0 (11.237M)   : 0, 11237158

    section Automatic
    This PR (4607) (8.123M)   : 0, 8123161
    master (7.863M)   : 0, 7862541
    benchmarks/2.37.0 (7.620M)   : 0, 7620446
    benchmarks/2.9.0 (7.980M)   : 0, 7979544

    section Trace stats
    master (7.980M)   : 0, 7979693
    benchmarks/2.37.0 (7.601M)   : 0, 7601244

    section Manual
    This PR (4607) (10.271M)   : 0, 10270602
    master (10.255M)   : 0, 10254734
    benchmarks/2.37.0 (9.672M)   : 0, 9672017

    section Manual + Automatic
    This PR (4607) (7.465M)   : 0, 7464867
    master (7.694M)   : 0, 7693543
    benchmarks/2.37.0 (7.271M)   : 0, 7270501

    section Version Conflict
    master (6.890M)   : 0, 6890041
    benchmarks/2.37.0 (6.624M)   : 0, 6624248
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4607) (9.561M)   : 0, 9560797
    master (9.675M)   : 0, 9675262
    benchmarks/2.37.0 (9.603M)   : 0, 9603393
    benchmarks/2.9.0 (9.575M)   : 0, 9574635

    section Automatic
    This PR (4607) (6.650M)   : 0, 6649732
    master (6.817M)   : 0, 6817226
    benchmarks/2.37.0 (6.484M)   : 0, 6483840

    section Trace stats
    master (6.805M)   : 0, 6804504
    benchmarks/2.37.0 (6.737M)   : 0, 6736780

    section Manual
    This PR (4607) (8.470M)   : 0, 8470405
    master (8.471M)   : 0, 8471390
    benchmarks/2.37.0 (8.509M)   : 0, 8508994

    section Manual + Automatic
    This PR (4607) (6.467M)   : 0, 6466629
    master (6.390M)   : 0, 6389737
    benchmarks/2.37.0 (6.542M)   : 0, 6542042

    section Version Conflict
    master (5.845M)   : 0, 5845419
    benchmarks/2.37.0 (5.769M)   : 0, 5769174
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4607) (9.445M)   : 0, 9444947
    master (9.232M)   : 0, 9232390
    benchmarks/2.37.0 (9.641M)   : 0, 9641281
    benchmarks/2.9.0 (9.346M)   : 0, 9345561

    section Automatic
    This PR (4607) (6.739M)   : 0, 6738868
    master (6.534M)   : 0, 6533540
    benchmarks/2.37.0 (6.809M)   : 0, 6809282
    benchmarks/2.9.0 (6.752M)   : 0, 6751930

    section Trace stats
    master (6.706M)   : 0, 6705540
    benchmarks/2.37.0 (6.650M)   : 0, 6649920

    section Manual
    This PR (4607) (8.532M)   : 0, 8531500
    master (8.578M)   : 0, 8577575
    benchmarks/2.37.0 (8.352M)   : 0, 8352046

    section Manual + Automatic
    This PR (4607) (6.485M)   : 0, 6484837
    master (6.451M)   : 0, 6450701
    benchmarks/2.37.0 (6.611M)   : 0, 6611182

    section Version Conflict
    master (5.927M)   : 0, 5927280
    benchmarks/2.37.0 (6.067M)   : 0, 6067045
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4607) (7.263M)   : 0, 7262873
    master (7.177M)   : 0, 7176721
    benchmarks/2.37.0 (7.626M)   : 0, 7626233
    benchmarks/2.9.0 (7.928M)   : 0, 7928406

    section No attack
    This PR (4607) (2.083M)   : 0, 2083371
    master (2.118M)   : 0, 2118152
    benchmarks/2.37.0 (2.192M)   : 0, 2192041
    benchmarks/2.9.0 (3.365M)   : 0, 3365217

    section Attack
    This PR (4607) (1.671M)   : 0, 1670750
    master (1.687M)   : 0, 1687037
    benchmarks/2.37.0 (1.697M)   : 0, 1696915
    benchmarks/2.9.0 (2.632M)   : 0, 2631585

    section Blocking
    This PR (4607) (3.104M)   : 0, 3103874
    master (3.029M)   : 0, 3028746
    benchmarks/2.37.0 (3.146M)   : 0, 3146410
Loading

@anna-git anna-git merged commit 00fc1b6 into master Sep 11, 2023
51 checks passed
@anna-git anna-git deleted the anna/add-logs-artifacts-throughputs branch September 11, 2023 10:35
@github-actions github-actions bot added this to the vNext milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
2.38.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anna-git @andrewlock