[ASM] Update waf ruleset to 1.8 #4633

anna-git · 2023-09-18T09:53:22Z

Summary of changes

Update default ruleset for waf to run on
Adapt integration tests

Reason for change

New ruleset released https://github.com/DataDog/appsec-event-rules/pull/167

Implementation details

Change rule-set.json to 1.8 for waf default ruleset.

Test coverage

Same tests

github-actions · 2023-09-18T09:54:12Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

14 occurrences of :

-      _dd.appsec.event_rules.version: 1.7.2,
+      _dd.appsec.event_rules.version: 1.8.0,

datadog-ddstaging · 2023-09-18T10:14:58Z

Datadog Report

Branch report: anna/asm/update-waf-ruleset
Commit report: 9a60882

❄️ dd-trace-dotnet: 0 Failed, 3 New Flaky, 302719 Passed, 1154 Skipped, 25m 18.38s Wall Time

New Flaky Tests (3)

UpdateMemoryLeakCheck - Datadog.Trace.Security.Unit.Tests.WafMemoryTests - Last Failure
Expand for error
```
 Expected current to be less than or equal to 851574016L, but found 856707072L.
```
UpdateMemoryLeakCheck - Datadog.Trace.Security.Unit.Tests.WafMemoryTests - Last Failure
Expand for error
```
 Expected current to be less than or equal to 845217024L, but found 846684160L.
```
UpdateMemoryLeakCheck - Datadog.Trace.Security.Unit.Tests.WafMemoryTests - Last Failure
Expand for error
```
 Expected current to be less than or equal to 862141696L, but found 868061184L.
```

andrewlock · 2023-09-18T10:18:26Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4633) - mean (74ms)  : 59, 89
     .   : milestone, 74,
    master - mean (71ms)  : 63, 79
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4633) - mean (1,053ms)  : 1016, 1091
     .   : milestone, 1053,
    master - mean (1,032ms)  : 1014, 1049
     .   : milestone, 1032,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4633) - mean (106ms)  : 100, 112
     .   : milestone, 106,
    master - mean (106ms)  : 100, 111
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4633) - mean (747ms)  : 732, 762
     .   : milestone, 747,
    master - mean (745ms)  : 725, 764
     .   : milestone, 745,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4633) - mean (89ms)  : 86, 93
     .   : milestone, 89,
    master - mean (89ms)  : 84, 95
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (4633) - mean (708ms)  : 695, 721
     .   : milestone, 708,
    master - mean (707ms)  : 683, 731
     .   : milestone, 707,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4633) - mean (185ms)  : 177, 192
     .   : milestone, 185,
    master - mean (186ms)  : 178, 194
     .   : milestone, 186,

    section CallTarget+Inlining+NGEN
    This PR (4633) - mean (1,116ms)  : 1080, 1152
     .   : milestone, 1116,
    master - mean (1,114ms)  : 1078, 1150
     .   : milestone, 1114,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4633) - mean (265ms)  : 254, 275
     .   : milestone, 265,
    master - mean (268ms)  : 255, 282
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (4633) - mean (1,081ms)  : 1056, 1106
     .   : milestone, 1081,
    master - mean (1,087ms)  : 1057, 1118
     .   : milestone, 1087,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4633) - mean (258ms)  : 245, 270
     .   : milestone, 258,
    master - mean (257ms)  : 245, 270
     .   : milestone, 257,

    section CallTarget+Inlining+NGEN
    This PR (4633) - mean (1,043ms)  : 1016, 1069
     .   : milestone, 1043,
    master - mean (1,040ms)  : 1005, 1075
     .   : milestone, 1040,

andrewlock · 2023-09-18T10:40:17Z

Benchmarks Report 🐌

Benchmarks for #4633 compared to master:

1 benchmarks are faster, with geometric mean 1.152
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.36μs	45.4ns	276ns	0.0202	0.00807	0	7.3 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	49.5ns	227ns	0.025	0.01	0	7.38 KB
master	`StartStopWithChild`	net472	15.5μs	41.9ns	162ns	1.27	0.314	0.0919	7.65 KB
#4633	`StartStopWithChild`	net6.0	8.1μs	40.9ns	192ns	0.0249	0.0124	0	7.29 KB
#4633	`StartStopWithChild`	netcoreapp3.1	10.2μs	51.5ns	252ns	0.0297	0.0149	0	7.38 KB
#4633	`StartStopWithChild`	net472	15.5μs	68.4ns	265ns	1.28	0.321	0.102	7.66 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	477μs	253ns	911ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	631μs	232ns	867ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	808μs	333ns	1.2μs	0.406	3.3 KB
#4633	`WriteAndFlushEnrichedTraces`	net6.0	479μs	108ns	405ns	0	2.7 KB
#4633	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	643μs	225ns	813ns	0	2.7 KB
#4633	`WriteAndFlushEnrichedTraces`	net472	808μs	328ns	1.27μs	0.403	3.3 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	42.1μs	17.8ns	69ns	0.0213	0	2.03 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	43.9μs	90.4ns	350ns	0.0219	0	2.01 KB
master	`AllCycleSimpleBody`	net472	45.6μs	102ns	396ns	0.315	0	2.08 KB
master	`AllCycleMoreComplexBody`	net6.0	229μs	75.8ns	263ns	0	0	8.63 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	233μs	106ns	397ns	0.117	0	8.52 KB
master	`AllCycleMoreComplexBody`	net472	237μs	73.3ns	284ns	1.3	0	8.7 KB
master	`ObjectExtractorSimpleBody`	net6.0	120ns	0.0661ns	0.247ns	0.00394	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	184ns	0.0762ns	0.285ns	0.0037	0	272 B
master	`ObjectExtractorSimpleBody`	net472	146ns	0.0734ns	0.284ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	2.96μs	0.644ns	2.41ns	0.055	0	3.88 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.02μs	1.77ns	6.84ns	0.0523	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	net472	4.1μs	1.32ns	4.58ns	0.618	0.0062	3.89 KB
#4633	`AllCycleSimpleBody`	net6.0	44.1μs	72.6ns	281ns	0.0215	0	2.03 KB
#4633	`AllCycleSimpleBody`	netcoreapp3.1	44.7μs	34.1ns	128ns	0.0225	0	2.01 KB
#4633	`AllCycleSimpleBody`	net472	46.7μs	90.6ns	351ns	0.323	0	2.08 KB
#4633	`AllCycleMoreComplexBody`	net6.0	227μs	82ns	296ns	0.114	0	8.63 KB
#4633	`AllCycleMoreComplexBody`	netcoreapp3.1	232μs	124ns	465ns	0	0	8.52 KB
#4633	`AllCycleMoreComplexBody`	net472	237μs	99ns	384ns	1.31	0	8.7 KB
#4633	`ObjectExtractorSimpleBody`	net6.0	121ns	0.0374ns	0.135ns	0.00393	0	280 B
#4633	`ObjectExtractorSimpleBody`	netcoreapp3.1	171ns	0.0829ns	0.31ns	0.0037	0	272 B
#4633	`ObjectExtractorSimpleBody`	net472	145ns	0.0853ns	0.33ns	0.0446	0	281 B
#4633	`ObjectExtractorMoreComplexBody`	net6.0	3.07μs	1.05ns	3.91ns	0.0541	0	3.88 KB
#4633	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.97μs	0.884ns	3.31ns	0.0515	0	3.78 KB
#4633	`ObjectExtractorMoreComplexBody`	net472	4.06μs	2.63ns	10.2ns	0.617	0.00614	3.89 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`RunWaf(args=NestedMap (10))`	net6.0	12.7μs	5.24ns	19.6ns	0.133	0	9.42 KB
master	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	19.4μs	5.42ns	21ns	0.126	0	9.42 KB
master	`RunWaf(args=NestedMap (10))`	net472	28.1μs	7.95ns	30.8ns	1.5	0	9.48 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	77.7μs	36.3ns	141ns	0.194	0	15.77 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	87.3μs	110ns	411ns	0.173	0	15.72 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	99.4μs	64.2ns	249ns	2.52	0	16.04 KB
master	`RunWaf(args=NestedMap (100))`	net6.0	46.2μs	37.9ns	142ns	0.302	0	21.64 KB
master	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	64.7μs	48.1ns	180ns	0.291	0	22.47 KB
master	`RunWaf(args=NestedMap (100))`	net472	82.2μs	51.8ns	201ns	3.7	0.0411	23.28 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	123μs	111ns	431ns	0.368	0	27.98 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	148μs	284ns	1.1μs	0.367	0	28.78 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	175μs	189ns	730ns	4.7	0.087	29.85 KB
master	`RunWaf(args=NestedMap (1000))`	net6.0	44.3μs	58.4ns	219ns	0.289	0	21.64 KB
master	`RunWaf(args=NestedMap (1000))`	netcoreapp3.1	62.3μs	65.7ns	246ns	0.281	0	22.47 KB
master	`RunWaf(args=NestedMap (1000))`	net472	83.4μs	84.3ns	326ns	3.67	0.0417	23.28 KB
master	`RunWafWithAttack(args=Neste(...)tack) [24])`	net6.0	124μs	111ns	429ns	0.371	0	27.98 KB
master	`RunWafWithAttack(args=Neste(...)tack) [24])`	netcoreapp3.1	147μs	251ns	938ns	0.368	0	28.77 KB
master	`RunWafWithAttack(args=Neste(...)tack) [24])`	net472	172μs	233ns	902ns	4.73	0.0845	29.85 KB
#4633	`RunWaf(args=NestedMap (10))`	net6.0	12.7μs	3.66ns	13.7ns	0.129	0	9.42 KB
#4633	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	19.7μs	4.2ns	15.7ns	0.127	0	9.42 KB
#4633	`RunWaf(args=NestedMap (10))`	net472	28.1μs	7.35ns	28.5ns	1.5	0	9.48 KB
#4633	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	76.8μs	129ns	498ns	0.191	0	15.77 KB
#4633	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	84.7μs	154ns	578ns	0.21	0	15.72 KB
#4633	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	99.3μs	64ns	248ns	2.51	0	16.04 KB
#4633	`RunWaf(args=NestedMap (100))`	net6.0	44.4μs	43.5ns	169ns	0.287	0	21.64 KB
#4633	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	62.6μs	83.4ns	323ns	0.28	0	22.47 KB
#4633	`RunWaf(args=NestedMap (100))`	net472	81.2μs	40.4ns	151ns	3.69	0.0405	23.29 KB
#4633	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	123μs	148ns	574ns	0.37	0	27.98 KB
#4633	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	145μs	169ns	655ns	0.359	0	28.78 KB
#4633	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	170μs	301ns	1.17μs	4.74	0.0846	29.85 KB
#4633	`RunWaf(args=NestedMap (1000))`	net6.0	44.8μs	52.6ns	197ns	0.292	0	21.64 KB
#4633	`RunWaf(args=NestedMap (1000))`	netcoreapp3.1	62.2μs	59.9ns	224ns	0.31	0	22.47 KB
#4633	`RunWaf(args=NestedMap (1000))`	net472	81.4μs	73.1ns	283ns	3.7	0.0406	23.28 KB
#4633	`RunWafWithAttack(args=Neste(...)tack) [24])`	net6.0	127μs	101ns	391ns	0.381	0	27.98 KB
#4633	`RunWafWithAttack(args=Neste(...)tack) [24])`	netcoreapp3.1	144μs	148ns	573ns	0.36	0	28.77 KB
#4633	`RunWafWithAttack(args=Neste(...)tack) [24])`	net472	171μs	93.1ns	361ns	4.73	0.0845	29.85 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	170μs	147ns	571ns	0.255	18.09 KB
master	`SendRequest`	netcoreapp3.1	190μs	221ns	856ns	0.188	20.25 KB
master	`SendRequest`	net472	0.000331ns	0.000148ns	0.000534ns	0	0 b
#4633	`SendRequest`	net6.0	169μs	194ns	753ns	0.251	18.09 KB
#4633	`SendRequest`	netcoreapp3.1	189μs	274ns	1.06μs	0.189	20.25 KB
#4633	`SendRequest`	net472	0.000946ns	0.000364ns	0.00141ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	500μs	2.3μs	8.9μs	0.519	0	0	41.45 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	627μs	494ns	1.91μs	0.311	0	0	41.66 KB
master	`WriteAndFlushEnrichedTraces`	net472	774μs	3.36μs	13μs	8.31	2.37	0.396	53.24 KB
#4633	`WriteAndFlushEnrichedTraces`	net6.0	490μs	386ns	1.39μs	0.519	0	0	41.39 KB
#4633	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	630μs	1.26μs	4.88μs	0.306	0	0	41.86 KB
#4633	`WriteAndFlushEnrichedTraces`	net472	774μs	3.73μs	14.9μs	8.36	2.39	0.398	53.23 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.05μs	0.66ns	2.56ns	0.0106	768 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.31μs	1.1ns	4.26ns	0.01	768 B
master	`ExecuteNonQuery`	net472	1.65μs	1.78ns	6.9ns	0.115	730 B
#4633	`ExecuteNonQuery`	net6.0	1.11μs	0.59ns	2.21ns	0.0106	768 B
#4633	`ExecuteNonQuery`	netcoreapp3.1	1.34μs	0.485ns	1.75ns	0.01	768 B
#4633	`ExecuteNonQuery`	net472	1.67μs	0.904ns	3.13ns	0.116	730 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.25μs	0.723ns	2.8ns	0.0139	0	992 B
master	`CallElasticsearch`	netcoreapp3.1	1.39μs	3.26ns	12.6ns	0.0133	0	992 B
master	`CallElasticsearch`	net472	2.35μs	0.834ns	3.12ns	0.159	0.00118	1 KB
master	`CallElasticsearchAsync`	net6.0	1.37μs	0.628ns	2.35ns	0.0137	0	968 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.53μs	0.553ns	2.07ns	0.0139	0	1.04 KB
master	`CallElasticsearchAsync`	net472	2.39μs	0.588ns	2.28ns	0.168	0.00119	1.06 KB
#4633	`CallElasticsearch`	net6.0	1.15μs	0.881ns	3.29ns	0.0139	0	992 B
#4633	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.65ns	2.43ns	0.0136	0	992 B
#4633	`CallElasticsearch`	net472	2.28μs	0.94ns	3.64ns	0.159	0.00114	1 KB
#4633	`CallElasticsearchAsync`	net6.0	1.28μs	0.714ns	2.67ns	0.0134	0	968 B
#4633	`CallElasticsearchAsync`	netcoreapp3.1	1.51μs	0.569ns	2.13ns	0.0136	0	1.04 KB
#4633	`CallElasticsearchAsync`	net472	2.47μs	0.833ns	3.23ns	0.168	0.00124	1.06 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.26μs	0.854ns	3.19ns	0.0127	0	912 B
master	`ExecuteAsync`	netcoreapp3.1	1.43μs	0.537ns	2.01ns	0.0121	0	912 B
master	`ExecuteAsync`	net472	1.63μs	1.45ns	5.63ns	0.138	0.000814	875 B
#4633	`ExecuteAsync`	net6.0	1.26μs	0.593ns	2.3ns	0.0129	0	912 B
#4633	`ExecuteAsync`	netcoreapp3.1	1.48μs	0.978ns	3.79ns	0.012	0	912 B
#4633	`ExecuteAsync`	net472	1.7μs	0.78ns	3.02ns	0.138	0.000849	875 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	3.89μs	1.14ns	4.28ns	0.0263	1.94 KB
master	`SendAsync`	netcoreapp3.1	4.45μs	2ns	7.47ns	0.0333	2.48 KB
master	`SendAsync`	net472	7.02μs	0.956ns	3.45ns	0.484	3.05 KB
#4633	`SendAsync`	net6.0	3.89μs	1.76ns	6.84ns	0.0271	1.94 KB
#4633	`SendAsync`	netcoreapp3.1	4.45μs	3.81ns	14.3ns	0.0335	2.48 KB
#4633	`SendAsync`	net472	7.13μs	2.73ns	10.6ns	0.485	3.05 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.29μs	0.725ns	2.71ns	0.0225	1.62 KB
master	`EnrichedLog`	netcoreapp3.1	2.08μs	2.78ns	10.8ns	0.0217	1.62 KB
master	`EnrichedLog`	net472	2.4μs	1.53ns	5.72ns	0.244	1.54 KB
#4633	`EnrichedLog`	net6.0	1.3μs	0.824ns	3.19ns	0.0232	1.62 KB
#4633	`EnrichedLog`	netcoreapp3.1	1.91μs	2.38ns	9.2ns	0.0219	1.62 KB
#4633	`EnrichedLog`	net472	2.34μs	1.19ns	4.59ns	0.244	1.54 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	111μs	115ns	447ns	0.0556	0	4.21 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	280ns	1.09μs	0	0	4.21 KB
master	`EnrichedLog`	net472	148μs	130ns	503ns	0.663	0.221	4.38 KB
#4633	`EnrichedLog`	net6.0	116μs	128ns	494ns	0.0578	0	4.21 KB
#4633	`EnrichedLog`	netcoreapp3.1	118μs	175ns	677ns	0.0588	0	4.21 KB
#4633	`EnrichedLog`	net472	147μs	71.6ns	268ns	0.658	0.219	4.38 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.49ns	5.78ns	0.0301	2.18 KB
master	`EnrichedLog`	netcoreapp3.1	3.88μs	1.02ns	3.67ns	0.0291	2.18 KB
master	`EnrichedLog`	net472	4.48μs	2.84ns	11ns	0.316	1.99 KB
#4633	`EnrichedLog`	net6.0	2.94μs	1.84ns	7.12ns	0.031	2.18 KB
#4633	`EnrichedLog`	netcoreapp3.1	3.73μs	2.35ns	9.12ns	0.0295	2.18 KB
#4633	`EnrichedLog`	net472	4.43μs	4.29ns	16.1ns	0.314	1.99 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.3μs	1.17ns	4.53ns	0.0162	1.16 KB
master	`SendReceive`	netcoreapp3.1	1.69μs	0.718ns	2.69ns	0.0152	1.16 KB
master	`SendReceive`	net472	2.09μs	1.67ns	6.25ns	0.184	1.16 KB
#4633	`SendReceive`	net6.0	1.32μs	0.553ns	2.07ns	0.0159	1.16 KB
#4633	`SendReceive`	netcoreapp3.1	1.64μs	0.703ns	2.63ns	0.0156	1.16 KB
#4633	`SendReceive`	net472	2.04μs	0.857ns	3.32ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.61μs	1.07ns	3.99ns	0.0209	1.53 KB
master	`EnrichedLog`	netcoreapp3.1	3.49μs	1.27ns	4.75ns	0.0209	1.58 KB
master	`EnrichedLog`	net472	4.07μs	1.04ns	3.89ns	0.31	1.96 KB
#4633	`EnrichedLog`	net6.0	2.65μs	0.693ns	2.59ns	0.021	1.53 KB
#4633	`EnrichedLog`	netcoreapp3.1	3.55μs	1.46ns	5.47ns	0.0212	1.58 KB
#4633	`EnrichedLog`	net472	3.98μs	1.22ns	4.73ns	0.31	1.96 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4633

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.152	607.49	527.56

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	394ns	0.163ns	0.612ns	0.00743	536 B
master	`StartFinishSpan`	netcoreapp3.1	607ns	0.391ns	1.51ns	0.00729	536 B
master	`StartFinishSpan`	net472	613ns	0.329ns	1.28ns	0.0854	538 B
master	`StartFinishScope`	net6.0	500ns	0.205ns	0.768ns	0.0092	656 B
master	`StartFinishScope`	netcoreapp3.1	814ns	0.296ns	1.07ns	0.00893	656 B
master	`StartFinishScope`	net472	814ns	0.192ns	0.744ns	0.0978	618 B
#4633	`StartFinishSpan`	net6.0	385ns	0.155ns	0.578ns	0.00741	536 B
#4633	`StartFinishSpan`	netcoreapp3.1	528ns	0.209ns	0.752ns	0.00735	536 B
#4633	`StartFinishSpan`	net472	567ns	0.195ns	0.754ns	0.0853	538 B
#4633	`StartFinishScope`	net6.0	502ns	0.247ns	0.958ns	0.00929	656 B
#4633	`StartFinishScope`	netcoreapp3.1	749ns	0.187ns	0.698ns	0.00864	656 B
#4633	`StartFinishScope`	net472	813ns	0.5ns	1.93ns	0.0979	618 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	658ns	2.26ns	8.74ns	0.00918	656 B
master	`RunOnMethodBegin`	netcoreapp3.1	789ns	0.248ns	0.896ns	0.00882	656 B
master	`RunOnMethodBegin`	net472	898ns	0.435ns	1.63ns	0.0978	618 B
#4633	`RunOnMethodBegin`	net6.0	601ns	0.207ns	0.804ns	0.0093	656 B
#4633	`RunOnMethodBegin`	netcoreapp3.1	722ns	0.317ns	1.14ns	0.00894	656 B
#4633	`RunOnMethodBegin`	net472	944ns	0.268ns	1ns	0.0979	618 B

daniel-romano-DD

👍

anna-git added 2 commits September 18, 2023 11:32

Change ruleset

a9a3f96

Adapt snapshots

9a60882

anna-git requested a review from a team as a code owner September 18, 2023 09:53

github-actions bot added the area:asm label Sep 18, 2023

daniel-romano-DD approved these changes Sep 19, 2023

View reviewed changes

anna-git merged commit 1f7e5c3 into master Sep 19, 2023
49 of 51 checks passed

anna-git deleted the anna/asm/update-waf-ruleset branch September 19, 2023 12:13

github-actions bot added this to the vNext milestone Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ASM] Update waf ruleset to 1.8 #4633

[ASM] Update waf ruleset to 1.8 #4633

anna-git commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

datadog-ddstaging bot commented Sep 18, 2023 •

edited

Loading

andrewlock commented Sep 18, 2023

andrewlock commented Sep 18, 2023

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #4633

Raw results

Raw results

daniel-romano-DD left a comment

[ASM] Update waf ruleset to 1.8 #4633

[ASM] Update waf ruleset to 1.8 #4633

Conversation

anna-git commented Sep 18, 2023

Summary of changes

Reason for change

Implementation details

Test coverage

github-actions bot commented Sep 18, 2023

Snapshots difference summary

datadog-ddstaging bot commented Sep 18, 2023 • edited Loading

Datadog Report

New Flaky Tests (3)

andrewlock commented Sep 18, 2023

Execution-Time Benchmarks Report ⏱️

andrewlock commented Sep 18, 2023

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #4633

Raw results

Raw results

daniel-romano-DD left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Sep 18, 2023 •

edited

Loading