Fix dotnet_tool build #5470

andrewlock · 2024-04-19T12:03:06Z

Summary of changes

Update the dotnet_tool build stage to disable MSBuild Node Reuse

Reason for change

In v3, we have added Fody to two projects, Datadog.Trace and Datadog.Trace.Coverage.Collector. Unfortunately, this seems to trigger a bug in Fody when we build the dotnet runner tool which references both of these attributes.

Implementation details

The issue appears to be some sort of race condition. Disabling MSBuild node reuse solves the issue.

Initially I tried just using the dotnet build switch /nodereuse:false but that didn't solve the issue for dotnet pack so switched to setting the env var. However, setting the env var solely in the Nuke build step also didn't seem to solve the issue, so set it globally in that build stage and it worked. I couldn't work out why, but my best I can guess is that a sub MSBuild is created and it doesn't inherit the parent environment 🤷‍♂️ The important thing is it works

Test coverage

Ran a full build based on v3 and it worked 🎉

Other details

This is only required for v3, but doesn't hurt to merge it here, so would rather keep that branch smaller

datadog-ddstaging · 2024-04-19T12:03:17Z

Datadog Report

Branch report: andrew/v3-public-apis/node-reuse-false
Commit report: c964b89
Test service: dd-trace-dotnet

✅ 0 Failed, 342232 Passed, 1539 Skipped, 41m 51.66s Wall Time

andrewlock · 2024-04-19T12:31:12Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5470) - mean (72ms)  : 65, 80
     .   : milestone, 72,
    master - mean (72ms)  : 65, 80
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (5470) - mean (1,025ms)  : 1005, 1045
     .   : milestone, 1025,
    master - mean (1,021ms)  : 1000, 1042
     .   : milestone, 1021,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5470) - mean (111ms)  : 106, 117
     .   : milestone, 111,
    master - mean (111ms)  : 107, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (5470) - mean (735ms)  : 714, 755
     .   : milestone, 735,
    master - mean (739ms)  : 715, 764
     .   : milestone, 739,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5470) - mean (94ms)  : 92, 97
     .   : milestone, 94,
    master - mean (95ms)  : 91, 98
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (5470) - mean (693ms)  : 674, 712
     .   : milestone, 693,
    master - mean (694ms)  : 669, 719
     .   : milestone, 694,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5470) - mean (190ms)  : 187, 194
     .   : milestone, 190,
    master - mean (190ms)  : 188, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5470) - mean (1,096ms)  : 1077, 1115
     .   : milestone, 1096,
    master - mean (1,097ms)  : 1074, 1120
     .   : milestone, 1097,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5470) - mean (275ms)  : 271, 279
     .   : milestone, 275,
    master - mean (277ms)  : 273, 280
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5470) - mean (886ms)  : 857, 915
     .   : milestone, 886,
    master - mean (890ms)  : 863, 917
     .   : milestone, 890,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5470) - mean (263ms)  : 259, 267
     .   : milestone, 263,
    master - mean (264ms)  : 260, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5470) - mean (869ms)  : 840, 898
     .   : milestone, 869,
    master - mean (868ms)  : 846, 890
     .   : milestone, 868,

andrewlock · 2024-04-19T12:49:02Z

Benchmarks Report for tracer 🐌

Benchmarks for #5470 compared to master:

1 benchmarks are faster, with geometric mean 1.117
1 benchmarks are slower, with geometric mean 1.120
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.83μs	47.4ns	268ns	0.0217	0.00868	0	7.56 KB
master	`StartStopWithChild`	netcoreapp3.1	10.8μs	58.9ns	349ns	0.028	0.0112	0	7.65 KB
master	`StartStopWithChild`	net472	17.5μs	67.6ns	262ns	1.35	0.354	0.104	8.1 KB
#5470	`StartStopWithChild`	net6.0	8.77μs	44.8ns	215ns	0.0214	0.00855	0	7.56 KB
#5470	`StartStopWithChild`	netcoreapp3.1	11.1μs	57.5ns	293ns	0.0322	0.0161	0	7.64 KB
#5470	`StartStopWithChild`	net472	17.3μs	38.6ns	150ns	1.37	0.38	0.104	8.11 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	455μs	378ns	1.42μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	612μs	251ns	906ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	825μs	656ns	2.54μs	0.411	3.3 KB
#5470	`WriteAndFlushEnrichedTraces`	net6.0	462μs	70.7ns	255ns	0	2.7 KB
#5470	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	639μs	173ns	648ns	0	2.7 KB
#5470	`WriteAndFlushEnrichedTraces`	net472	825μs	370ns	1.38μs	0.411	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	172μs	251ns	972ns	0.172	18.49 KB
master	`SendRequest`	netcoreapp3.1	194μs	191ns	716ns	0.194	20.66 KB
master	`SendRequest`	net472	0.00123ns	0.000517ns	0.002ns	0	0 b
#5470	`SendRequest`	net6.0	170μs	142ns	531ns	0.257	18.49 KB
#5470	`SendRequest`	netcoreapp3.1	192μs	368ns	1.43μs	0.19	20.65 KB
#5470	`SendRequest`	net472	0.000406ns	0.000204ns	0.000735ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5470

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.91 KB	41.7 KB	-217 B	-0.52%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	538μs	666ns	2.58μs	0.563	0	0	41.52 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	651ns	2.35μs	0.322	0	0	41.91 KB
master	`WriteAndFlushEnrichedTraces`	net472	867μs	3.94μs	15.3μs	8.25	2.6	0.434	53.27 KB
#5470	`WriteAndFlushEnrichedTraces`	net6.0	548μs	595ns	2.23μs	0.579	0	0	41.59 KB
#5470	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	1.07μs	4μs	0.326	0	0	41.7 KB
#5470	`WriteAndFlushEnrichedTraces`	net472	844μs	2.69μs	10.1μs	8.13	2.57	0.428	53.25 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.22μs	0.505ns	1.89ns	0.0116	808 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.5μs	1.08ns	4.03ns	0.0105	808 B
master	`ExecuteNonQuery`	net472	1.74μs	0.521ns	1.95ns	0.122	770 B
#5470	`ExecuteNonQuery`	net6.0	1.2μs	0.645ns	2.5ns	0.0114	808 B
#5470	`ExecuteNonQuery`	netcoreapp3.1	1.54μs	1.42ns	5.3ns	0.0106	808 B
#5470	`ExecuteNonQuery`	net472	1.77μs	0.302ns	1.13ns	0.122	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.3μs	0.841ns	3.26ns	0.0144	0	1.03 KB
master	`CallElasticsearch`	netcoreapp3.1	1.68μs	1.6ns	6.18ns	0.014	0	1.03 KB
master	`CallElasticsearch`	net472	2.52μs	2.1ns	7.85ns	0.166	0	1.04 KB
master	`CallElasticsearchAsync`	net6.0	1.47μs	1.3ns	5.05ns	0.014	0	1.01 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	1.73μs	1.28ns	4.97ns	0.0147	0	1.08 KB
master	`CallElasticsearchAsync`	net472	2.7μs	1.37ns	5.31ns	0.174	0.00135	1.1 KB
#5470	`CallElasticsearch`	net6.0	1.26μs	0.613ns	2.29ns	0.0146	0	1.03 KB
#5470	`CallElasticsearch`	netcoreapp3.1	1.57μs	1.38ns	5.33ns	0.0142	0	1.03 KB
#5470	`CallElasticsearch`	net472	2.52μs	1.99ns	7.45ns	0.165	0	1.04 KB
#5470	`CallElasticsearchAsync`	net6.0	1.4μs	1.15ns	4.45ns	0.0139	0	1.01 KB
#5470	`CallElasticsearchAsync`	netcoreapp3.1	1.72μs	0.717ns	2.58ns	0.0148	0	1.08 KB
#5470	`CallElasticsearchAsync`	net472	2.63μs	0.865ns	3.35ns	0.174	0.00132	1.1 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.36μs	0.852ns	3.19ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.898ns	3.36ns	0.013	952 B
master	`ExecuteAsync`	net472	1.84μs	2.32ns	8.97ns	0.145	915 B
#5470	`ExecuteAsync`	net6.0	1.41μs	0.771ns	2.99ns	0.0133	952 B
#5470	`ExecuteAsync`	netcoreapp3.1	1.71μs	1.1ns	4.27ns	0.0128	952 B
#5470	`ExecuteAsync`	net472	1.76μs	0.754ns	2.72ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.29μs	2.57ns	9.95ns	0.0327	2.27 KB
master	`SendAsync`	netcoreapp3.1	5.12μs	1.62ns	5.63ns	0.0385	2.81 KB
master	`SendAsync`	net472	7.86μs	3.71ns	14.4ns	0.503	3.18 KB
#5470	`SendAsync`	net6.0	4.44μs	3.44ns	11.9ns	0.0311	2.27 KB
#5470	`SendAsync`	netcoreapp3.1	5.39μs	22.8ns	82.2ns	0.036	2.81 KB
#5470	`SendAsync`	net472	7.77μs	2.98ns	11.6ns	0.504	3.18 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.53μs	0.663ns	2.57ns	0.0237	1.7 KB
master	`EnrichedLog`	netcoreapp3.1	2.32μs	9.85ns	38.1ns	0.0228	1.7 KB
master	`EnrichedLog`	net472	2.68μs	1.42ns	5.31ns	0.257	1.62 KB
#5470	`EnrichedLog`	net6.0	1.65μs	0.735ns	2.75ns	0.024	1.7 KB
#5470	`EnrichedLog`	netcoreapp3.1	2.2μs	0.732ns	2.74ns	0.0235	1.7 KB
#5470	`EnrichedLog`	net472	2.64μs	3.37ns	12.2ns	0.256	1.62 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	115μs	74.3ns	278ns	0.0568	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	172ns	621ns	0.0586	0	4.28 KB
master	`EnrichedLog`	net472	151μs	173ns	669ns	0.686	0.229	4.46 KB
#5470	`EnrichedLog`	net6.0	114μs	335ns	1.3μs	0.0572	0	4.28 KB
#5470	`EnrichedLog`	netcoreapp3.1	120μs	246ns	953ns	0.0599	0	4.28 KB
#5470	`EnrichedLog`	net472	152μs	141ns	544ns	0.679	0.226	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.98μs	1.56ns	5.82ns	0.0313	2.25 KB
master	`EnrichedLog`	netcoreapp3.1	4.19μs	1.5ns	5.62ns	0.0293	2.25 KB
master	`EnrichedLog`	net472	4.96μs	2.44ns	9.44ns	0.327	2.07 KB
#5470	`EnrichedLog`	net6.0	3.01μs	1.34ns	5.2ns	0.0317	2.25 KB
#5470	`EnrichedLog`	netcoreapp3.1	4.31μs	1.63ns	5.89ns	0.03	2.25 KB
#5470	`EnrichedLog`	net472	5.04μs	1.78ns	6.65ns	0.329	2.07 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.54μs	0.777ns	2.91ns	0.0169	1.2 KB
master	`SendReceive`	netcoreapp3.1	1.8μs	0.882ns	3.3ns	0.0163	1.2 KB
master	`SendReceive`	net472	2.13μs	0.626ns	2.34ns	0.191	1.2 KB
#5470	`SendReceive`	net6.0	1.53μs	1.16ns	4.34ns	0.0168	1.2 KB
#5470	`SendReceive`	netcoreapp3.1	1.86μs	0.9ns	3.49ns	0.0159	1.2 KB
#5470	`SendReceive`	net472	2.16μs	1.11ns	4.17ns	0.191	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.68μs	0.667ns	2.5ns	0.0214	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	4.01μs	2.04ns	7.9ns	0.0221	1.65 KB
master	`EnrichedLog`	net472	4.49μs	2.52ns	9.44ns	0.322	2.04 KB
#5470	`EnrichedLog`	net6.0	2.59μs	0.582ns	2.1ns	0.022	1.6 KB
#5470	`EnrichedLog`	netcoreapp3.1	3.96μs	1.35ns	5.06ns	0.0218	1.65 KB
#5470	`EnrichedLog`	net472	4.4μs	1.14ns	4.27ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5470

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.117	789.50	706.96

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	543ns	0.267ns	1ns	0.00806	576 B
master	`StartFinishSpan`	netcoreapp3.1	787ns	2.64ns	9.54ns	0.0076	576 B
master	`StartFinishSpan`	net472	811ns	3.02ns	11.7ns	0.0914	578 B
master	`StartFinishScope`	net6.0	558ns	0.162ns	0.607ns	0.00965	696 B
master	`StartFinishScope`	netcoreapp3.1	883ns	0.561ns	2.17ns	0.00936	696 B
master	`StartFinishScope`	net472	1.01μs	1.37ns	5.33ns	0.104	658 B
#5470	`StartFinishSpan`	net6.0	529ns	0.503ns	1.88ns	0.00804	576 B
#5470	`StartFinishSpan`	netcoreapp3.1	708ns	0.808ns	2.91ns	0.00787	576 B
#5470	`StartFinishSpan`	net472	845ns	0.77ns	2.98ns	0.0917	578 B
#5470	`StartFinishScope`	net6.0	610ns	0.495ns	1.92ns	0.00972	696 B
#5470	`StartFinishScope`	netcoreapp3.1	797ns	1.48ns	5.53ns	0.00956	696 B
#5470	`StartFinishScope`	net472	1.06μs	0.748ns	2.9ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5470

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.120	595.30	667.01

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	595ns	0.542ns	2.1ns	0.00977	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	980ns	1.31ns	5.07ns	0.00931	696 B
master	`RunOnMethodBegin`	net472	1.11μs	1.27ns	4.93ns	0.104	658 B
#5470	`RunOnMethodBegin`	net6.0	667ns	0.194ns	0.75ns	0.00963	696 B
#5470	`RunOnMethodBegin`	netcoreapp3.1	912ns	0.798ns	3.09ns	0.00957	696 B
#5470	`RunOnMethodBegin`	net472	1.14μs	0.702ns	2.63ns	0.104	658 B

bouwkast

Looks like it built 👍

andrewlock · 2024-04-19T13:15:46Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5470) (11.404M)   : 0, 11403757
    master (11.115M)   : 0, 11114505
    benchmarks/2.9.0 (11.346M)   : 0, 11346488

    section Automatic
    This PR (5470) (7.880M)   : 0, 7879877
    master (7.617M)   : 0, 7616968
    benchmarks/2.9.0 (8.024M)   : 0, 8024430

    section Trace stats
    master (8.063M)   : 0, 8062831

    section Manual
    This PR (5470) (9.790M)   : 0, 9790302
    master (9.709M)   : 0, 9708727

    section Manual + Automatic
    This PR (5470) (7.306M)   : 0, 7306015
    master (7.359M)   : 0, 7359187

    section Version Conflict
    master (6.628M)   : 0, 6627893

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5470) (9.524M)   : 0, 9523781
    master (9.703M)   : 0, 9703097
    benchmarks/2.9.0 (9.650M)   : 0, 9649801

    section Automatic
    This PR (5470) (6.710M)   : 0, 6710366
    master (6.434M)   : 0, 6434247

    section Trace stats
    master (6.951M)   : 0, 6951366

    section Manual
    This PR (5470) (8.083M)   : 0, 8082788
    master (8.280M)   : 0, 8279673

    section Manual + Automatic
    This PR (5470) (6.210M)   : 0, 6210369
    master (6.289M)   : 0, 6289187

    section Version Conflict
    master (5.662M)   : 0, 5662020

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5470) (9.929M)   : 0, 9928942
    master (10.242M)   : 0, 10242209
    benchmarks/2.9.0 (10.057M)   : 0, 10057128

    section Automatic
    This PR (5470) (6.883M)   : 0, 6882905
    master (7.190M)   : 0, 7189816
    benchmarks/2.9.0 (7.487M)   : 0, 7486565

    section Trace stats
    master (7.449M)   : 0, 7448644

    section Manual
    This PR (5470) (8.734M)   : 0, 8733913
    master (8.841M)   : 0, 8841469

    section Manual + Automatic
    This PR (5470) (6.733M)   : 0, 6732609
    master (6.911M)   : 0, 6911465

    section Version Conflict
    master (6.254M)   : 0, 6253944

andrewlock added 2 commits April 19, 2024 11:55

Force MSBUILDDISABLENODEREUSE where required

8a7dad0

Try using the env var

c964b89

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 19, 2024

andrewlock requested a review from a team as a code owner April 19, 2024 12:03

bouwkast approved these changes Apr 19, 2024

View reviewed changes

kevingosse approved these changes Apr 19, 2024

View reviewed changes

andrewlock merged commit 32a28c0 into master Apr 19, 2024
57 checks passed

andrewlock deleted the andrew/v3-public-apis/node-reuse-false branch April 19, 2024 14:37

github-actions bot added this to the vNext-v2 milestone Apr 19, 2024

andrewlock mentioned this pull request Apr 22, 2024

FileLoadException: Assembly with same name is already loaded when multiple Fody-using projects are referenced Fody/Fody#1268

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix dotnet_tool build #5470

Fix dotnet_tool build #5470

andrewlock commented Apr 19, 2024

datadog-ddstaging bot commented Apr 19, 2024 •

edited

andrewlock commented Apr 19, 2024

andrewlock commented Apr 19, 2024

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5470

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5470

Raw results

Slower ⚠️ in #5470

Raw results

bouwkast left a comment

andrewlock commented Apr 19, 2024

Fix dotnet_tool build #5470

Fix dotnet_tool build #5470

Conversation

andrewlock commented Apr 19, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Apr 19, 2024 • edited

Datadog Report

andrewlock commented Apr 19, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Apr 19, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5470

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5470

Raw results

Slower ⚠️ in #5470

Raw results

bouwkast left a comment

Choose a reason for hiding this comment

andrewlock commented Apr 19, 2024

Throughput/Crank Report:zap:

datadog-ddstaging bot commented Apr 19, 2024 •

edited