Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/99designs/gqlgen: bump version in go.mod #1452

Closed
nathan-genies opened this issue Aug 29, 2022 · 3 comments
Closed

contrib/99designs/gqlgen: bump version in go.mod #1452

nathan-genies opened this issue Aug 29, 2022 · 3 comments
Labels
bug unintended behavior that has to be fixed
Milestone

Comments

@nathan-genies
Copy link

Hello,

We're trying to leverage the tracing library for 99designs but looks like the current code is not compatible with the latest 99design release. Could you take a look and maybe use vendor/ to provide a stable release? Thanks!

go mod tidy
go: finding module for package gopkg.in/DataDog/dd-trace-go.v1/contrib/99designs/gqlgen
go: found gopkg.in/DataDog/dd-trace-go.v1/contrib/99designs/gqlgen in gopkg.in/DataDog/dd-trace-go.v1 v1.41.0
go: finding module for package github.com/99designs/gqlgen/example/todo
go: found github.com/99designs/gqlgen/example/todo in github.com/99designs/gqlgen/example v0.0.0-20220208183958-9262b35865e4
go: github.com/99designs/gqlgen/example@v0.0.0-20220208183958-9262b35865e4 requires
        github.com/99designs/gqlgen@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000
make: *** [vendor] Error 1
@david-alza
Copy link
Contributor

Just jumping in to say we're facing the same thing when trying to add this (we're on gqlgen v0.17.16).

I wonder if there was a specific reason to integrate this originally against v0.14? 3918783#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R7

@katiehockman
Copy link
Contributor

Thanks for filing an issue and sending a PR 👍

@katiehockman katiehockman added the bug unintended behavior that has to be fixed label Sep 2, 2022
@katiehockman katiehockman added this to the 1.42.0 milestone Sep 2, 2022
@katiehockman katiehockman changed the title Error importing github.com/99designs/gqlgen/example/todo contrib/99designs/gqlgen: bump version in go.mod Sep 2, 2022
@knusbaum knusbaum modified the milestones: 1.42.0, 1.43.0 Sep 19, 2022
@ajgajg1134
Copy link
Contributor

Resolved in #1457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behavior that has to be fixed
Projects
None yet
Development

No branches or pull requests

5 participants