Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: support opentracing #175

Closed
FlamingTree opened this issue Feb 6, 2018 · 8 comments
Closed

contrib: support opentracing #175

FlamingTree opened this issue Feb 6, 2018 · 8 comments
Labels
apm:ecosystem contrib/* related feature requests or bugs opentracing

Comments

@FlamingTree
Copy link

is there plan?

@gbbr gbbr changed the title library of contrib directory support opentracing contrib: support opentracing Feb 6, 2018
@gbbr
Copy link
Contributor

gbbr commented Feb 6, 2018

@FlamingTree we are working on this as we speak. Should be available soon. It's planned for 0.7.0

@gbbr gbbr added the apm:ecosystem contrib/* related feature requests or bugs label Feb 6, 2018
@jontonsoup
Copy link

What is the state of this / the docs? Everything seems outdated.

I'm having major issues finding examples that show how to properly do anything with open tracing and the "supported" libraries.

I'd love an example of one clean setup where a full request via gin is traced with sql (gorm) and redis. Does this exist?

@gbbr
Copy link
Contributor

gbbr commented May 30, 2018

Hey @jontonsoup - you can try out our new v1 tracer. It's under the branch with the same name (v1). It's pretty thoroughly documented in its godoc pages. The opentracer package should be what you're looking for and should be pretty straightforward. Integrations should just work out of the box. We will be releasing this within the next two weeks.

Let me know how it goes and I'm happy to work with you here if you run into trouble.

@jontonsoup
Copy link

@gbbr thank you!

I will try this out and see what happens.

Will this url be updated in the future so I dont have to pin to a branch?
gopkg.in/DataDog/dd-trace-go.v1

@gbbr
Copy link
Contributor

gbbr commented May 30, 2018

The URL will stay gopkg.in/DataDog/dd-trace-go.v1 and will point to the correct release. Once we release though, we will probably create a tag v1.0.0 so that it's semver friendly and leave the v1 branch as a development branch. You're good to go using that URL.

I'm not sure if I understood your question correctly, but once we release new minor releases, we will most likely update that URL too. However, it's always safest that you pin down a branch/commit in whatever dependency management solution you are using, be it dep or vgo.

@jontonsoup
Copy link

@gbbr

Any intuition on this?

Using dep

dep ensure -add gopkg.in/DataDog/dd-trace-go.v1

Solving failure: No versions of gopkg.in/DataDog/dd-trace-go.v1 met constraints:
	v1: Could not introduce gopkg.in/DataDog/dd-trace-go.v1@v1, as its subpackage gopkg.in/DataDog/dd-trace-go.v1 does not contain usable Go code (*build.NoGoError).. (Package is required by (root).)

@jontonsoup
Copy link

okay I lied. Just need to import the sub packages individually.

dep ensure -add gopkg.in/DataDog/dd-trace-go.v1/ddtrace

@gbbr
Copy link
Contributor

gbbr commented Jun 1, 2018

I am going to close this, since our contrib folder holds integrations for the Datadog tracer. The integrations for Opentracing are found on the official repository: https://github.com/opentracing-contrib

@gbbr gbbr closed this as completed Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs opentracing
Projects
None yet
Development

No branches or pull requests

3 participants