ddtrace/tracer: fix rate limiter moving average #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbll
approved these changes
Jan 11, 2021
knusbaum
changed the title
knusbaum
requested changes
Jan 11, 2021
ddtrace/tracer/sampler_test.go
Outdated
Comment on lines
473
to
474
| assert.Equal(float64(100), sl.seen) | ||
| assert.Equal(float64(42), sl.allowed) |
There was a problem hiding this comment.
Can we use 100.0 and 42.0 here rather than using conversion, for consistency?
arbll
previously approved these changes
Jan 11, 2021
raphaelgavache
force-pushed
the
raphael/fix_rate_name
branch
from
6d70e8e
to
094cb94
Compare
knusbaum
approved these changes
Jan 11, 2021
dianashevchenko
pushed a commit
that referenced
this pull request
Feb 8, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to sampling rate name: since twl rules,
_dd.agent_psris they name to the priority rate pulled from the agent and applied to the root.Fixing the limiter rate moving average