ddtrace/tracer: refactor log debug and format tests #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoledanuwidjaja
force-pushed
the
nicoledanuwidjaja/fix-log-format-test
branch
from
f642c46
to
caeb004
Compare
nicoledanuwidjaja
force-pushed
the
nicoledanuwidjaja/fix-log-format-test
branch
from
caeb004
to
09a47dc
Compare
nicoledanuwidjaja
changed the title
gbbr
approved these changes
Feb 11, 2021
|
Thanks! |
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
TestLogFormatin log_test.go by not checking tag contents. Update tests to pass in spancontext_test.go and tracer_test.go